Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1125703002: [CSS Grid Layout] Refactoring of grid's alignment logic (Closed)

Created:
5 years, 7 months ago by jfernandez
Modified:
5 years ago
CC:
blink-reviews, jfernandez, blink-reviews-rendering, zoltan1, svillar, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, jchaffraix+rendering, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] Refactoring of grid's alignment logic After so many patches related to Box Alignment spec implmementation for Grid Layout, it seems the code and logic ended up a bit complex and confusing, overall when dealing with differetn writing modes and directions. This patch tries to simplify the codebase for implementing the alignment logic in Grid Layout. BUG=79180 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196983

Patch Set 1 #

Total comments: 8

Patch Set 2 : Applied suggested changes. #

Patch Set 3 : Fixed bug in overflow handling logic. #

Patch Set 4 : Patch rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -199 lines) Patch
M Source/core/layout/LayoutGrid.h View 1 2 3 2 chunks +3 lines, -8 lines 0 comments Download
M Source/core/layout/LayoutGrid.cpp View 1 2 3 4 chunks +116 lines, -191 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
jfernandez
5 years, 7 months ago (2015-05-20 14:41:55 UTC) #2
svillar
Nice refactoring. That's a lgtm https://codereview.chromium.org/1125703002/diff/1/Source/core/layout/LayoutGrid.cpp File Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/1125703002/diff/1/Source/core/layout/LayoutGrid.cpp#newcode1462 Source/core/layout/LayoutGrid.cpp:1462: // FIXME: grid track ...
5 years, 6 months ago (2015-06-10 08:27:21 UTC) #4
jfernandez
Applied suggested changes. I'm going to try the CQ now. https://codereview.chromium.org/1125703002/diff/1/Source/core/layout/LayoutGrid.cpp File Source/core/layout/LayoutGrid.cpp (right): https://codereview.chromium.org/1125703002/diff/1/Source/core/layout/LayoutGrid.cpp#newcode1462 ...
5 years, 6 months ago (2015-06-11 12:00:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125703002/20001
5 years, 6 months ago (2015-06-11 12:01:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/66183)
5 years, 6 months ago (2015-06-11 13:33:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125703002/40001
5 years, 6 months ago (2015-06-11 20:54:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/47260) mac_blink_rel on tryserver.blink (JOB_FAILED, ...
5 years, 6 months ago (2015-06-11 20:57:55 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125703002/60001
5 years, 6 months ago (2015-06-11 23:19:32 UTC) #18
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 00:18:23 UTC) #19
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196983

Powered by Google App Engine
This is Rietveld 408576698