Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp - Issue 1125683002: Avoid nearly identical toImplArray() and toImplHeapArray()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

Issue 1125683002: Avoid nearly identical toImplArray() and toImplHeapArray() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestDictionary.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

index ffd43a37194622a00808621652dadaf7bf285f01..4ed9effe4302c8b1169e0d9c707a0afc73b1c438 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

@@ -78,13 +78,13 @@ static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info)

dictionaryArg = Dictionary(info[3], info.GetIsolate(), exceptionState);

if (exceptionState.throwIfNeeded())

return;

- sequenceStringArg = toImplArray<String>(info[4], 5, info.GetIsolate(), exceptionState);

+ sequenceStringArg = toImplArray<Vector<String>>(info[4], 5, info.GetIsolate(), exceptionState);

if (exceptionState.throwIfNeeded())

return;

- sequenceDictionaryArg = toImplArray<Dictionary>(info[5], 6, info.GetIsolate(), exceptionState);

+ sequenceDictionaryArg = toImplArray<Vector<Dictionary>>(info[5], 6, info.GetIsolate(), exceptionState);

if (exceptionState.throwIfNeeded())

return;

- sequenceLongOrTestDictionaryArg = toImplArray<LongOrTestDictionary>(info[6], 7, info.GetIsolate(), exceptionState);

+ sequenceLongOrTestDictionaryArg = toImplArray<Vector<LongOrTestDictionary>>(info[6], 7, info.GetIsolate(), exceptionState);

if (exceptionState.throwIfNeeded())

return;

if (!isUndefinedOrNull(info[7]) && !info[7]->IsObject()) {