Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1125673010: freed_nodes in global-handles should be addititive (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

freed_nodes in global-handles should be addititive otherwise phantom nodes won't ever be taken into account BUG=chromium:484671, chromium:479796 R=hpayer@chromium.org LOG=y Committed: https://crrev.com/7e67b48694852ed1fa5870310b2ab473f5e0e65d Cr-Commit-Position: refs/heads/master@{#28234}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/global-handles.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-05 15:09:04 UTC) #1
ulan
lgtm
5 years, 7 months ago (2015-05-05 15:10:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125673010/1
5 years, 7 months ago (2015-05-05 15:15:34 UTC) #5
Hannes Payer (out of office)
lgtm
5 years, 7 months ago (2015-05-05 15:29:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 15:37:37 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 15:37:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e67b48694852ed1fa5870310b2ab473f5e0e65d
Cr-Commit-Position: refs/heads/master@{#28234}

Powered by Google App Engine
This is Rietveld 408576698