Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1125673004: Makes AXNodeObject test if it's a table cell or row before calling isPresentationalInTable. (Closed)

Created:
5 years, 7 months ago by je_julie(Not used)
Modified:
5 years, 7 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, nektarios, dmazzoni, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Makes AXNodeObject test if it's a table cell or row before calling isPresentationalInTable. The API, isPresentationalInTable(), is to see whether the current node is a table cell or a table row and its parent has a presentational role. If the current node is not a table cell or a table row, we don't need to call it. This patch adds conditions at inheritsPresentationalRoleFrom() to test whether it is a table-cell or a table-row. BUG=484501 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
je_julie(Not used)
Hi Dominic, This patch makes AXNodeObject test if it's a cell or row of table ...
5 years, 7 months ago (2015-05-04 15:52:42 UTC) #2
dmazzoni
lgtm I'm assuming this is a speculative fix for the isPresentationalInTable crash? Please add the ...
5 years, 7 months ago (2015-05-04 16:00:05 UTC) #3
je_julie(Not used)
On 2015/05/04 16:00:05, dmazzoni wrote: > lgtm > > I'm assuming this is a speculative ...
5 years, 7 months ago (2015-05-05 02:45:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125673004/1
5 years, 7 months ago (2015-05-05 02:47:45 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 05:09:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194908

Powered by Google App Engine
This is Rietveld 408576698