Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 1125653002: [chrome/browser/password_manager] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser/password_manager module. MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Committed: https://crrev.com/47870b56de9d736e98f733883bd537aac735969b Cr-Commit-Position: refs/heads/master@{#328281}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/browser/password_manager/password_store_factory.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_mac_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 2 chunks +2 lines, -1 line 3 comments Download
M chrome/browser/password_manager/password_store_x_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Pranay
PTAL, Thanks
5 years, 7 months ago (2015-05-04 07:58:24 UTC) #2
vabr (Chromium)
LGTM with a comment. Thanks for this CL! Vaclav https://codereview.chromium.org/1125653002/diff/1/chrome/browser/password_manager/password_store_win_unittest.cc File chrome/browser/password_manager/password_store_win_unittest.cc (right): https://codereview.chromium.org/1125653002/diff/1/chrome/browser/password_manager/password_store_win_unittest.cc#newcode14 chrome/browser/password_manager/password_store_win_unittest.cc:14: ...
5 years, 7 months ago (2015-05-04 16:10:13 UTC) #3
Pranay
https://codereview.chromium.org/1125653002/diff/1/chrome/browser/password_manager/password_store_win_unittest.cc File chrome/browser/password_manager/password_store_win_unittest.cc (right): https://codereview.chromium.org/1125653002/diff/1/chrome/browser/password_manager/password_store_win_unittest.cc#newcode14 chrome/browser/password_manager/password_store_win_unittest.cc:14: #include "base/message_loop/message_loop.h" Hi Vabr, Yes it's still needed for ...
5 years, 7 months ago (2015-05-05 03:14:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125653002/1
5 years, 7 months ago (2015-05-05 03:15:34 UTC) #6
vabr (Chromium)
Still LGTM. Thanks! Vaclav https://codereview.chromium.org/1125653002/diff/1/chrome/browser/password_manager/password_store_win_unittest.cc File chrome/browser/password_manager/password_store_win_unittest.cc (right): https://codereview.chromium.org/1125653002/diff/1/chrome/browser/password_manager/password_store_win_unittest.cc#newcode14 chrome/browser/password_manager/password_store_win_unittest.cc:14: #include "base/message_loop/message_loop.h" On 2015/05/05 03:14:57, ...
5 years, 7 months ago (2015-05-05 03:18:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 05:20:25 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 05:21:30 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47870b56de9d736e98f733883bd537aac735969b
Cr-Commit-Position: refs/heads/master@{#328281}

Powered by Google App Engine
This is Rietveld 408576698