Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 1125623002: X87: Use a stub in crankshaft for grow store arrays. (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Use a stub in crankshaft for grow store arrays. port fb8e6136387339e8089bbf61d4ffee50e4cd957e (r28163). original commit message: We were deopting without learning anything. This is a rebase/reland of https://codereview.chromium.org/368263003 BUG= Committed: https://crrev.com/906152b85a83ed3c655a154e929039861889770d Cr-Commit-Position: refs/heads/master@{#28188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M src/x87/interface-descriptors-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
chunyang.dai
PTAL.
5 years, 7 months ago (2015-05-04 02:44:59 UTC) #2
chunyang.dai
PTAL.
5 years, 7 months ago (2015-05-04 02:45:03 UTC) #3
Weiliang
lgtm
5 years, 7 months ago (2015-05-04 03:14:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125623002/1
5 years, 7 months ago (2015-05-04 03:14:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-04 03:39:20 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 03:39:32 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/906152b85a83ed3c655a154e929039861889770d
Cr-Commit-Position: refs/heads/master@{#28188}

Powered by Google App Engine
This is Rietveld 408576698