Issue 1125593003: Update WeakBindToProxy to support new InterfacePtr interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1125593003: Update WeakBindToProxy to support new InterfacePtr interface. (Closed)

Created:
5 years, 7 months ago by Ken Rockot(use gerrit already)

Modified:
5 years, 7 months ago

Reviewers:
yzshen1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Update WeakBindToProxy to support new InterfacePtr interface. Some legacy code still depends on this. BUG= R=yzshen@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fccb32d26e7a58b64113cf3dac00a1c570d64c58

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	mojo/public/cpp/bindings/interface_impl.h	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yzshen1

LGTM Thanks! I think code in the mojo repo doesn't depends on it anymore so ...

5 years, 7 months ago (2015-05-05 20:32:05 UTC) #2

Ken Rockot(use gerrit already)

5 years, 7 months ago (2015-05-05 20:33:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fccb32d26e7a58b64113cf3dac00a1c570d64c58 (presubmit successful).

Expand Messages | Collapse Messages