Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1125423005: Do not create the NativeViewport PlatformEventSource when headless. (Closed)

Created:
5 years, 7 months ago by msw
Modified:
5 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not create the NativeViewport PlatformEventSource when headless. The Chromium Linux Mojo bot's app_tests step started failing here: http://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Linux/builds/7090 Related to https://codereview.chromium.org/1130353008/ The mojo:view_manager_apptests all crash after passing with: [0518/132408:FATAL:x11_event_source.cc(80)] Check failed: display_. These tests are run headless and shouldn't need an event source. BUG=NONE TEST=Bot goes green. R=jam@chromium.org Committed: https://crrev.com/67582621d7bfcb763c07d7a7605ba3bc200b4b5c Cr-Commit-Position: refs/heads/master@{#330433}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/native_viewport/native_viewport_application_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
msw
Hey John, please take a look; thanks!
5 years, 7 months ago (2015-05-18 21:21:55 UTC) #1
jam
lgtm
5 years, 7 months ago (2015-05-18 21:22:48 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125423005/1
5 years, 7 months ago (2015-05-18 21:23:14 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-18 21:35:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125423005/1
5 years, 7 months ago (2015-05-18 21:40:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 21:46:25 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:44:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67582621d7bfcb763c07d7a7605ba3bc200b4b5c
Cr-Commit-Position: refs/heads/master@{#330433}

Powered by Google App Engine
This is Rietveld 408576698