Issue 1125413007: Revert of Fix GcdPrivateAPITest.WifiPasswords on win 7 dbg

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1125413007: Revert of Fix GcdPrivateAPITest.WifiPasswords on win 7 dbg (Closed)

Created:
5 years, 7 months ago by sergeyv

Modified:
5 years, 7 months ago

Reviewers:
asargent_no_longer_on_chrome

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Fix GcdPrivateAPITest.WifiPasswords on win 7 dbg (patchset #1 id:1 of https://codereview.chromium.org/1128913003/) Reason for revert: Doesnt fix GcdPrivateAPITest.WifiPasswords on win dbg: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win7%20Tests%20%28dbg%29%281%29&number=37945 Original issue's description: > Fix GcdPrivateAPITest.WifiPasswords on win 7 dbg > TBR=vitalybuka > BUG=177163 > > Committed: https://crrev.com/81834cca312ad12091b40ebdab5ec9ca6db1c418 > Cr-Commit-Position: refs/heads/master@{#329615} TBR=asargent@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=177163 Committed: https://crrev.com/0110a68ffbba485573f212f0ecafabb10737766d Cr-Commit-Position: refs/heads/master@{#329620}

Created: 5 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/extensions/api/gcd_private/gcd_private_apitest.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

sergeyv

Created Revert of Fix GcdPrivateAPITest.WifiPasswords on win 7 dbg

5 years, 7 months ago (2015-05-13 12:54:28 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125413007/1

5 years, 7 months ago (2015-05-13 12:55:10 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-13 12:56:55 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0110a68ffbba485573f212f0ecafabb10737766d
Cr-Commit-Position: refs/heads/master@{#329620}