Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2038)

Unified Diff: chrome/browser/extensions/proxy_overridden_bubble_controller.cc

Issue 1125403006: [Extensions] Adjust strings in the extension message bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Latest master Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/google_chrome_strings.grd ('k') | chrome/browser/extensions/settings_api_bubble_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/proxy_overridden_bubble_controller.cc
diff --git a/chrome/browser/extensions/proxy_overridden_bubble_controller.cc b/chrome/browser/extensions/proxy_overridden_bubble_controller.cc
index f2f298c428f91ebc35283a51417db8718f506de4..3d81d16b86449be79663ae6e9f610d0221f3207a 100644
--- a/chrome/browser/extensions/proxy_overridden_bubble_controller.cc
+++ b/chrome/browser/extensions/proxy_overridden_bubble_controller.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/extensions/proxy_overridden_bubble_controller.h"
#include "base/metrics/histogram.h"
+#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/settings_api_helpers.h"
#include "chrome/browser/profiles/profile.h"
@@ -126,8 +127,14 @@ base::string16 ProxyOverriddenBubbleDelegate::GetMessageBody(
return l10n_util::GetStringUTF16(
IDS_EXTENSIONS_PROXY_CONTROLLED_FIRST_LINE_EXTENSION_SPECIFIC);
} else {
- return l10n_util::GetStringUTF16(
- IDS_EXTENSIONS_PROXY_CONTROLLED_FIRST_LINE);
+ const Extension* extension =
+ ExtensionRegistry::Get(profile())->GetExtensionById(
+ extension_id_, ExtensionRegistry::EVERYTHING);
+ // If the bubble is about to show, the extension should certainly exist.
+ CHECK(extension);
+ return l10n_util::GetStringFUTF16(
+ IDS_EXTENSIONS_PROXY_CONTROLLED_FIRST_LINE,
+ base::UTF8ToUTF16(extension->name()));
}
}
« no previous file with comments | « chrome/app/google_chrome_strings.grd ('k') | chrome/browser/extensions/settings_api_bubble_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698