Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1125403006: [Extensions] Adjust strings in the extension message bubble (Closed)

Created:
5 years, 7 months ago by Devlin
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Adjust strings in the extension message bubble Adjust the strings in the extension message bubble to indicate which extension is overriding certain settings if it's not point to a specific one. If it is pointing to a specific one, use "This extension". BUG=485614 Committed: https://crrev.com/5b9b392da0f2fb995f14bea06c11f87a3c33510a Cr-Commit-Position: refs/heads/master@{#329873}

Patch Set 1 #

Patch Set 2 : Latest master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -43 lines) Patch
M chrome/app/chromium_strings.grd View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 chunks +11 lines, -5 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/proxy_overridden_bubble_controller.cc View 1 2 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/extensions/settings_api_bubble_controller.cc View 1 2 chunks +39 lines, -32 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Devlin
Antony, mind taking a look? This fixes the strings in crbug.com/485614; the anchoring is being ...
5 years, 7 months ago (2015-05-08 17:13:17 UTC) #2
asargent_no_longer_on_chrome
lgtm
5 years, 7 months ago (2015-05-08 19:15:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125403006/1
5 years, 7 months ago (2015-05-08 22:04:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/55474)
5 years, 7 months ago (2015-05-09 00:57:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125403006/20001
5 years, 7 months ago (2015-05-14 17:00:38 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 17:53:15 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 17:54:56 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5b9b392da0f2fb995f14bea06c11f87a3c33510a
Cr-Commit-Position: refs/heads/master@{#329873}

Powered by Google App Engine
This is Rietveld 408576698