Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1125373004: Spoken text for [...] button on login screen (Closed)

Created:
5 years, 7 months ago by Greg Levin
Modified:
5 years, 7 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Spoken text for [...] button on login screen BUG=488666 Add spoken feedback but no visible text to button that leads to "Add supervised user" Committed: https://crrev.com/8e8e7c6b144594312e6e00ddd902dd9408e70c46 Cr-Commit-Position: refs/heads/master@{#330532}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove extra </button> #

Total comments: 3

Patch Set 3 : Use aria-label #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/header_bar.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Greg Levin
Please have a look! https://codereview.chromium.org/1125373004/diff/1/chrome/browser/resources/chromeos/login/header_bar.css File chrome/browser/resources/chromeos/login/header_bar.css (right): https://codereview.chromium.org/1125373004/diff/1/chrome/browser/resources/chromeos/login/header_bar.css#newcode130 chrome/browser/resources/chromeos/login/header_bar.css:130: font-size: 0; This seemed like ...
5 years, 7 months ago (2015-05-16 00:57:01 UTC) #2
dzhioev (left Google)
https://codereview.chromium.org/1125373004/diff/20001/chrome/browser/resources/chromeos/login/header_bar.css File chrome/browser/resources/chromeos/login/header_bar.css (right): https://codereview.chromium.org/1125373004/diff/20001/chrome/browser/resources/chromeos/login/header_bar.css#newcode130 chrome/browser/resources/chromeos/login/header_bar.css:130: font-size: 0; Can we use aria-label instead of invisible ...
5 years, 7 months ago (2015-05-16 01:26:56 UTC) #3
Greg Levin
Please have another look https://codereview.chromium.org/1125373004/diff/20001/chrome/browser/resources/chromeos/login/header_bar.css File chrome/browser/resources/chromeos/login/header_bar.css (right): https://codereview.chromium.org/1125373004/diff/20001/chrome/browser/resources/chromeos/login/header_bar.css#newcode130 chrome/browser/resources/chromeos/login/header_bar.css:130: font-size: 0; On 2015/05/16 01:26:56, ...
5 years, 7 months ago (2015-05-18 13:36:58 UTC) #4
dzhioev (left Google)
On 2015/05/18 13:36:58, Greg Levin wrote: > Please have another look > > https://codereview.chromium.org/1125373004/diff/20001/chrome/browser/resources/chromeos/login/header_bar.css > ...
5 years, 7 months ago (2015-05-19 15:57:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125373004/40001
5 years, 7 months ago (2015-05-19 16:04:50 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-19 17:09:47 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 17:11:30 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8e8e7c6b144594312e6e00ddd902dd9408e70c46
Cr-Commit-Position: refs/heads/master@{#330532}

Powered by Google App Engine
This is Rietveld 408576698