Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3860)

Unified Diff: chrome/browser/extensions/dev_mode_bubble_controller.cc

Issue 1125353002: Make extensions developer mode warning controllable by experiments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: changed how/where we check experiment values Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/dev_mode_bubble_controller.cc
diff --git a/chrome/browser/extensions/dev_mode_bubble_controller.cc b/chrome/browser/extensions/dev_mode_bubble_controller.cc
index d6914e503a83524f100fc598604e207161009ae6..643aa8654cf2c80eca1ffee5f24600976bbc2eec 100644
--- a/chrome/browser/extensions/dev_mode_bubble_controller.cc
+++ b/chrome/browser/extensions/dev_mode_bubble_controller.cc
@@ -77,7 +77,8 @@ bool DevModeBubbleDelegate::ShouldIncludeExtension(
const Extension* extension = service_->GetExtensionById(extension_id, false);
if (!extension)
return false;
- return DevModeBubbleController::IsDevModeExtension(extension);
+ return (extension->location() == Manifest::UNPACKED ||
+ extension->location() == Manifest::COMMAND_LINE);
}
void DevModeBubbleDelegate::AcknowledgeExtension(
@@ -154,17 +155,6 @@ void DevModeBubbleController::ClearProfileListForTesting() {
g_shown_for_profiles.Get().clear();
}
-// static
-bool DevModeBubbleController::IsDevModeExtension(
- const Extension* extension) {
- if (!FeatureSwitch::force_dev_mode_highlighting()->IsEnabled()) {
- if (chrome::VersionInfo::GetChannel() < chrome::VersionInfo::CHANNEL_BETA)
- return false;
- }
- return extension->location() == Manifest::UNPACKED ||
- extension->location() == Manifest::COMMAND_LINE;
-}
-
DevModeBubbleController::DevModeBubbleController(Profile* profile)
: ExtensionMessageBubbleController(new DevModeBubbleDelegate(profile),
profile),

Powered by Google App Engine
This is Rietveld 408576698