Make extensions developer mode warning controllable by experiments

chrome/browser/extensions/dev_mode_bubble_controller.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/dev_mode_bubble_controller.h"
 
+#include "base/command_line.h"
 #include "base/lazy_instance.h"
+#include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/extensions/extension_action_manager.h"
 #include "chrome/browser/extensions/extension_message_bubble.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_toolbar_model.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/grit/generated_resources.h"
 #include "extensions/browser/extension_prefs.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/common/feature_switch.h"
 #include "grit/components_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace extensions {
 
 namespace {
 
 base::LazyInstance<std::set<Profile*> > g_shown_for_profiles =
     LAZY_INSTANCE_INITIALIZER;
 
+const char kEnableDevModeWarningExperimentName[] =
+    "ExtensionDeveloperModeWarning";
+
+bool ShouldEnableBubble() {
+  if (FeatureSwitch::force_dev_mode_highlighting()->IsEnabled())
+    return true;
+
+  // Don't allow turning it off via command line.
+  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
+  if (command_line->HasSwitch(switches::kForceFieldTrials)) {
+    std::string forced_trials =
+        command_line->GetSwitchValueASCII(switches::kForceFieldTrials);
+    if (forced_trials.find(kEnableDevModeWarningExperimentName))
+      return true;
+  }
+
+  const std::string group = base::FieldTrialList::FindFullName(
+      kEnableDevModeWarningExperimentName);
+  return group == "Enabled";
+}
+
 ////////////////////////////////////////////////////////////////////////////////
 // DevModeBubbleDelegate
 
 class DevModeBubbleDelegate
     : public ExtensionMessageBubbleController::Delegate {
  public:
   explicit DevModeBubbleDelegate(Profile* profile);
   ~DevModeBubbleDelegate() override;
 
   // ExtensionMessageBubbleController::Delegate methods.
@@ skipping 29 matching lines @@
 }
 
 DevModeBubbleDelegate::~DevModeBubbleDelegate() {
 }
 
 bool DevModeBubbleDelegate::ShouldIncludeExtension(
     const std::string& extension_id) {
   const Extension* extension = service_->GetExtensionById(extension_id, false);
   if (!extension)
     return false;
-  return DevModeBubbleController::IsDevModeExtension(extension);
+  return (extension->location() == Manifest::UNPACKED ||
+          extension->location() == Manifest::COMMAND_LINE);
 }
 
 void DevModeBubbleDelegate::AcknowledgeExtension(
     const std::string& extension_id,
     ExtensionMessageBubbleController::BubbleAction user_action) {
 }
 
 void DevModeBubbleDelegate::PerformAction(const ExtensionIdList& list) {
   for (size_t i = 0; i < list.size(); ++i)
     service_->DisableExtension(list[i], Extension::DISABLE_USER_ACTION);
@@ skipping 56 matching lines @@
 }  // namespace
 
 ////////////////////////////////////////////////////////////////////////////////
 // DevModeBubbleController
 
 // static
 void DevModeBubbleController::ClearProfileListForTesting() {
   g_shown_for_profiles.Get().clear();
 }
 
-// static
-bool DevModeBubbleController::IsDevModeExtension(
-    const Extension* extension) {
-  if (!FeatureSwitch::force_dev_mode_highlighting()->IsEnabled()) {
-    if (chrome::VersionInfo::GetChannel() < chrome::VersionInfo::CHANNEL_BETA)
-      return false;
-  }
-  return extension->location() == Manifest::UNPACKED ||
-         extension->location() == Manifest::COMMAND_LINE;
-}
-
 DevModeBubbleController::DevModeBubbleController(Profile* profile)
     : ExtensionMessageBubbleController(new DevModeBubbleDelegate(profile),
                                        profile),
       profile_(profile) {}
 
 DevModeBubbleController::~DevModeBubbleController() {
 }
 
 bool DevModeBubbleController::ShouldShow() {
+  if (!ShouldEnableBubble())
+    return false;
+
   return !g_shown_for_profiles.Get().count(profile_->GetOriginalProfile()) &&
       !GetExtensionList().empty();
 }
 
 void DevModeBubbleController::Show(ExtensionMessageBubble* bubble) {
   g_shown_for_profiles.Get().insert(profile_->GetOriginalProfile());
   ExtensionMessageBubbleController::Show(bubble);
 }
 
 }  // namespace extensions