chrome/browser/ui/tab_helpers.h - Issue 1125343004: Add a "Simplify Page" option to the print preview dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.h

Issue 1125343004: Add a "Simplify Page" option to the print preview dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Refactoring following the proposals in the reviews Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/print_preview/settings/other_options_settings.js ('k') | chrome/browser/ui/webui/print_preview/print_preview_distiller.h » ('j') | chrome/browser/ui/webui/print_preview/print_preview_distiller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_helpers.h

diff --git a/chrome/browser/ui/tab_helpers.h b/chrome/browser/ui/tab_helpers.h

index 1c678f2b55a08b530b7c09e7db86c4f0b2ee0b15..44547d46f2b3b47110fa911b8f332bc89fdcf961 100644

--- a/chrome/browser/ui/tab_helpers.h

+++ b/chrome/browser/ui/tab_helpers.h

@@ -50,6 +50,10 @@ class TabHelpers {

// the full set of tab helpers to deal with it.

friend class prerender::PrerenderContents;

+ // The print preview distiller needs to generate print previews,

+ // which is supported by tab helpers.

Avi (use Gerrit) 2015/07/21 20:47:58 But not *all* the tab helpers. Please explicitly a

arjunpatel 2015/07/23 16:19:45 Acknowledged.

+ friend class PrintPreviewDistiller;

// Adopts the specified WebContents as a full-fledged browser tab, attaching

// all the associated tab helpers that are needed for the WebContents to

// serve in that role. It is safe to call this on a WebContents that was