chrome/browser/ui/webui/print_preview/print_preview_ui.cc - Issue 1125343004: Add a "Simplify Page" option to the print preview dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.cc

Issue 1125343004: Add a "Simplify Page" option to the print preview dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Simplify version of the HiddenPrintPreview and solved issues pointed out by the last review Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('K') | « chrome/browser/ui/webui/print_preview/print_preview_handler.cc ('k') | chrome/chrome_browser_ui.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/print_preview/print_preview_ui.cc

diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc

index 352eba5c1d5a92750fbad75a11975d6f83f5a9f3..454c85e3792e3e587a9336ff7f0b6e5c7e438073 100644

--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc

+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc

@@ -251,6 +251,8 @@ content::WebUIDataSource* CreatePrintPreviewUISource() {

source->AddLocalizedString("printPagesLabel",

IDS_PRINT_PREVIEW_PRINT_PAGES_LABEL);

source->AddLocalizedString("optionsLabel", IDS_PRINT_PREVIEW_OPTIONS_LABEL);

+ source->AddLocalizedString("optionPrintFriendly",

+ IDS_PRINT_PREVIEW_OPTION_PRINT_FRIENDLY);

source->AddLocalizedString("optionHeaderFooter",

IDS_PRINT_PREVIEW_OPTION_HEADER_FOOTER);

source->AddLocalizedString("optionFitToPage",