Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: net/cert/internal/verify_name_match.h

Issue 1125333005: RFC 2459 name comparison. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ios copy_test_data Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/internal/verify_name_match.h
diff --git a/net/cert/internal/verify_name_match.h b/net/cert/internal/verify_name_match.h
index de1dd877053f07e98d815686e70c64bff3d5d86e..99d09f0e1077b7c8781c5de0ccca818c88e0eab7 100644
--- a/net/cert/internal/verify_name_match.h
+++ b/net/cert/internal/verify_name_match.h
@@ -15,9 +15,11 @@ class Input;
} // namespace der
// Compare DER-encoded X.501 Name values according to RFC 5280 rules.
-// TODO(mattm): Doesn't actually implement RFC 5280 matching yet.
-// Returns true if |a| and |b| match.
-NET_EXPORT bool VerifyNameMatch(const der::Input& a, const der::Input& b);
+// |a_rdn_sequence| and |b_rdn_sequence| should be the DER-encoded RDNSequence
+// values (not including the Sequence tag).
+// Returns true if |a_rdn_sequence| and |b_rdn_sequence| match.
+NET_EXPORT bool VerifyNameMatch(const der::Input& a_rdn_sequence,
+ const der::Input& b_rdn_sequence);
} // namespace net

Powered by Google App Engine
This is Rietveld 408576698