eroman
2015/07/03 22:31:20
I suggest using PEM for all of these test files, r
I suggest using PEM for all of these test files, rather than binary DER.
(Ryan suggested this to me on one of my CLs too).
PEM has several advantages:
* Possible to read the diffs in Rietveld
* Can copy paste directly into tools like https://lapo.it/asn1js/ (which I
find very useful)
* You can include comments directly in the test file (not just the payload),
such as showing the pretty-printed ASN.1 structure
As an example I am using PEM for data files in this (unreviewed) changelist:
https://codereview.chromium.org/1209283004/
And find it works quite well for that purpose.
On 2015/07/03 22:31:20, eroman wrote:
> I suggest using PEM for all of these test files, rather than binary DER.
>
> (Ryan suggested this to me on one of my CLs too).
>
> PEM has several advantages:
> * Possible to read the diffs in Rietveld
> * Can copy paste directly into tools like https://lapo.it/asn1js/ (which I
> find very useful)
> * You can include comments directly in the test file (not just the payload),
> such as showing the pretty-printed ASN.1 structure
>
> As an example I am using PEM for data files in this (unreviewed) changelist:
> https://codereview.chromium.org/1209283004/
>
> And find it works quite well for that purpose.
Issue 1125333005: RFC 2459 name comparison.
(Closed)
Created 5 years, 7 months ago by mattm
Modified 5 years, 3 months ago
Reviewers: Ryan Sleevi, nharper, davidben, eroman, brettw
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 137