Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1125333003: Remove CheckMediaAccessPermission() from ContentBrowserClient. (Closed)

Created:
5 years, 7 months ago by Sergey Ulanov
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CheckMediaAccessPermission() from ContentBrowserClient. ContentBrowserClient::CheckMediaAccessPermissions() was added in crrev.com/292868, but it's not used anymore. Committed: https://crrev.com/5ca8a8d515b3fa91bb657ffa0930ec78b408bfeb Cr-Commit-Position: refs/heads/master@{#328798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -104 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/media/media_capture_devices_dispatcher.cc View 2 chunks +0 lines, -72 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Sergey Ulanov
5 years, 7 months ago (2015-05-06 22:32:53 UTC) #2
jam
lgtm
5 years, 7 months ago (2015-05-07 16:47:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125333003/1
5 years, 7 months ago (2015-05-07 17:16:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 18:28:38 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5ca8a8d515b3fa91bb657ffa0930ec78b408bfeb Cr-Commit-Position: refs/heads/master@{#328798}
5 years, 7 months ago (2015-05-07 18:29:37 UTC) #7
tommi (sloooow) - chröme
5 years, 7 months ago (2015-05-07 19:22:09 UTC) #8
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698