src/assembler_ia32.h - Issue 1125323004: Subzero: Use cmov to improve lowering for the select instruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/assembler_ia32.h

Issue 1125323004: Subzero: Use cmov to improve lowering for the select instruction. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Remove a rogue comment Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/assembler_ia32.h

diff --git a/src/assembler_ia32.h b/src/assembler_ia32.h

index f5675167be4d29da48580f1dbb4450aeb35b139b..2a928b0c5dc33e6f2fee850d626588f35a3fef71 100644

--- a/src/assembler_ia32.h

+++ b/src/assembler_ia32.h

@@ -510,7 +510,8 @@ public:

void lea(Type Ty, GPRRegister dst, const Address &src);

- void cmov(CondX86::BrCond cond, GPRRegister dst, GPRRegister src);

+ void cmov(Type Ty, CondX86::BrCond cond, GPRRegister dst, GPRRegister src);

+ void cmov(Type Ty, CondX86::BrCond cond, GPRRegister dst, const Address &src);

void rep_movsb();

« no previous file with comments | « src/IceTargetLoweringX8632.cpp ('k') | src/assembler_ia32.cpp » ('j') | no next file with comments »