Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1125313007: Add angle_unittests to Clang ToT buildbot test lists (Closed)

Created:
5 years, 7 months ago by hans
Modified:
5 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add angle_unittests to Clang ToT buildbot test lists These broke in the last roll attempt, and weren't caught by ToT bots :( BUG=452726 Committed: https://crrev.com/2f152dd88f52bf538e7d567e297da9757f48bb97 Cr-Commit-Position: refs/heads/master@{#330667}

Patch Set 1 #

Patch Set 2 : Add it to the WinClang bots too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -0 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 13 chunks +39 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
hans
Please take a look.
5 years, 7 months ago (2015-05-19 23:26:33 UTC) #2
Nico
lgtm
5 years, 7 months ago (2015-05-20 00:16:44 UTC) #3
Nico
Looks like we don't run this on the clang/win fyi bots either: http://build.chromium.org/p/chromium.fyi/builders/CrWinClang%20tester/builds/812 We probably ...
5 years, 7 months ago (2015-05-20 00:19:11 UTC) #4
hans
On 2015/05/20 00:19:11, Nico (afk until Thu May 21) wrote: > Looks like we don't ...
5 years, 7 months ago (2015-05-20 00:22:07 UTC) #5
Nico
lgtm, thanks!
5 years, 7 months ago (2015-05-20 00:23:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125313007/20001
5 years, 7 months ago (2015-05-20 00:25:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 01:26:28 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 01:28:06 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2f152dd88f52bf538e7d567e297da9757f48bb97
Cr-Commit-Position: refs/heads/master@{#330667}

Powered by Google App Engine
This is Rietveld 408576698