ios: add CrNet

ios: add CrNet

This code is copied directly from the downstream iOS repo, except for the
changes to ios/ios.gyp.

BUG=483209
Committed: https://crrev.com/a7ce8df915247cafcd8a0d27090c15c293b4fc51
Cr-Commit-Position: refs/heads/master@{#330952}

[Elly Fong-Jones, 2015-05-14 19:23:52]

ellyjones@chromium.org changed reviewers:
+ stuartmorgan@chromium.org

[Elly Fong-Jones, 2015-05-14 19:24:02]

stuart: PTAL? :)

[stuartmorgan, 2015-05-19 17:39:36]

The images should probably land separately; IIRC you still can't CQ a patch that
has binary files.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/DEPS
File ios/crnet/DEPS (right):

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/DEPS#newcode5
ios/crnet/DEPS:5: "+base/threading/worker_pool.h",
Are these three lines needed? Top-level DEPS includes +base/

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/DEPS#newcode9
ios/crnet/DEPS:9: "+ios/web/public/net/cookie_store_ios.h",
This is stale.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/DEPS#newcode41
ios/crnet/DEPS:41: "+net/url_request/url_request_job_factory_impl.h",
Do we actually want all of net to be file-by-file? Is there a reason not to just
allow net/?

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/DEPS#newcode42
ios/crnet/DEPS:42: "+webkit/common/user_agent/user_agent_util.h",
This is stale, and should go.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/OWNERS
File ios/crnet/OWNERS (right):

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/OWNERS#newcode4
ios/crnet/OWNERS:4: mef@google.com
These should all be @chromium.org

Also, I don't think huey should probably be here any more.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_consumer/cr...
File ios/crnet/crnet_consumer/crnet_consumer_app_delegate.h (right):

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_consumer/cr...
ios/crnet/crnet_consumer/crnet_consumer_app_delegate.h:16: @property (strong,
nonatomic) CrNetConsumerViewController* viewController;
No spaces after @property

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_consumer/cr...
File ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm (right):

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_consumer/cr...
ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm:39: // Just for fun,
don't route apple.com requests through CrNet.
Let's use a domain we control. How about chromium.org?

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_consumer/cr...
File ios/crnet/crnet_consumer/crnet_consumer_view_controller.m (right):

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_consumer/cr...
ios/crnet/crnet_consumer/crnet_consumer_view_controller.m:42: [NSURL
URLWithString:@"https://www.google.com"]]];
Fix indentation; should just be 4 relative to the previous line.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_consumer/cr...
ios/crnet/crnet_consumer/crnet_consumer_view_controller.m:43: 
Remove the blank line.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_net_log.cc
File ios/crnet/crnet_net_log.cc (right):

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_net_log.cc#...
ios/crnet/crnet_net_log.cc:1: // Copyright (c) 2015 The Chromium Authors. All
rights reserved.
Remove the (c)

[Elly Fong-Jones, 2015-05-20 22:02:26]

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/DEPS
File ios/crnet/DEPS (right):

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/DEPS#newcode5
ios/crnet/DEPS:5: "+base/threading/worker_pool.h",
On 2015/05/19 17:39:36, stuartmorgan wrote:
> Are these three lines needed? Top-level DEPS includes +base/

Done.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/DEPS#newcode9
ios/crnet/DEPS:9: "+ios/web/public/net/cookie_store_ios.h",
On 2015/05/19 17:39:36, stuartmorgan wrote:
> This is stale.

Done.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/DEPS#newcode41
ios/crnet/DEPS:41: "+net/url_request/url_request_job_factory_impl.h",
On 2015/05/19 17:39:36, stuartmorgan wrote:
> Do we actually want all of net to be file-by-file? Is there a reason not to
just
> allow net/?

Done.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/DEPS#newcode42
ios/crnet/DEPS:42: "+webkit/common/user_agent/user_agent_util.h",
On 2015/05/19 17:39:35, stuartmorgan wrote:
> This is stale, and should go.

Done.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/OWNERS
File ios/crnet/OWNERS (right):

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/OWNERS#newcode4
ios/crnet/OWNERS:4: mef@google.com
On 2015/05/19 17:39:36, stuartmorgan wrote:
> These should all be @chromium.org
> 
> Also, I don't think huey should probably be here any more.

Done.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_consumer/cr...
File ios/crnet/crnet_consumer/crnet_consumer_app_delegate.h (right):

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_consumer/cr...
ios/crnet/crnet_consumer/crnet_consumer_app_delegate.h:16: @property (strong,
nonatomic) CrNetConsumerViewController* viewController;
On 2015/05/19 17:39:36, stuartmorgan wrote:
> No spaces after @property

Done.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_consumer/cr...
File ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm (right):

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_consumer/cr...
ios/crnet/crnet_consumer/crnet_consumer_app_delegate.mm:39: // Just for fun,
don't route apple.com requests through CrNet.
On 2015/05/19 17:39:36, stuartmorgan wrote:
> Let's use a domain we control. How about chromium.org?

Done.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_consumer/cr...
File ios/crnet/crnet_consumer/crnet_consumer_view_controller.m (right):

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_consumer/cr...
ios/crnet/crnet_consumer/crnet_consumer_view_controller.m:42: [NSURL
URLWithString:@"https://www.google.com"]]];
On 2015/05/19 17:39:36, stuartmorgan wrote:
> Fix indentation; should just be 4 relative to the previous line.

Done.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_consumer/cr...
ios/crnet/crnet_consumer/crnet_consumer_view_controller.m:43: 
On 2015/05/19 17:39:36, stuartmorgan wrote:
> Remove the blank line.

Done.

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_net_log.cc
File ios/crnet/crnet_net_log.cc (right):

https://codereview.chromium.org/1125293004/diff/1/ios/crnet/crnet_net_log.cc#...
ios/crnet/crnet_net_log.cc:1: // Copyright (c) 2015 The Chromium Authors. All
rights reserved.
On 2015/05/19 17:39:36, stuartmorgan wrote:
> Remove the (c)

Done.

[stuartmorgan, 2015-05-21 13:37:59]

lgtm

https://codereview.chromium.org/1125293004/diff/60001/ios/crnet/DEPS
File ios/crnet/DEPS (right):

https://codereview.chromium.org/1125293004/diff/60001/ios/crnet/DEPS#newcode7
ios/crnet/DEPS:7: "+net"
Let's sort this list alphabetically.

https://codereview.chromium.org/1125293004/diff/60001/ios/crnet/crnet_consume...
File ios/crnet/crnet_consumer/crnet_consumer_view_controller.m (right):

https://codereview.chromium.org/1125293004/diff/60001/ios/crnet/crnet_consume...
ios/crnet/crnet_consumer/crnet_consumer_view_controller.m:6: #import "CrNet.h"
Blank line above this one.

https://codereview.chromium.org/1125293004/diff/60001/ios/crnet/crnet_consume...
ios/crnet/crnet_consumer/crnet_consumer_view_controller.m:15: UIButton* google =
[UIButton buttonWithType:UIButtonTypeSystem];
s/google/loadButton/

https://codereview.chromium.org/1125293004/diff/60001/ios/crnet/crnet_environ...
File ios/crnet/crnet_environment.h (right):

https://codereview.chromium.org/1125293004/diff/60001/ios/crnet/crnet_environ...
ios/crnet/crnet_environment.h:5: #ifndef CRNET_ENVIRONMENT_H_
Oops, the guard should be IOS_CRNET_CRNET_ENVIRONMENT_H_
(Remember to fix the #endif comment too)

[Elly Fong-Jones, 2015-05-21 15:42:49]

https://codereview.chromium.org/1125293004/diff/60001/ios/crnet/DEPS
File ios/crnet/DEPS (right):

https://codereview.chromium.org/1125293004/diff/60001/ios/crnet/DEPS#newcode7
ios/crnet/DEPS:7: "+net"
On 2015/05/21 13:37:59, stuartmorgan wrote:
> Let's sort this list alphabetically.

Done.

https://codereview.chromium.org/1125293004/diff/60001/ios/crnet/crnet_consume...
File ios/crnet/crnet_consumer/crnet_consumer_view_controller.m (right):

https://codereview.chromium.org/1125293004/diff/60001/ios/crnet/crnet_consume...
ios/crnet/crnet_consumer/crnet_consumer_view_controller.m:6: #import "CrNet.h"
On 2015/05/21 13:37:59, stuartmorgan wrote:
> Blank line above this one.

Done.

https://codereview.chromium.org/1125293004/diff/60001/ios/crnet/crnet_consume...
ios/crnet/crnet_consumer/crnet_consumer_view_controller.m:15: UIButton* google =
[UIButton buttonWithType:UIButtonTypeSystem];
On 2015/05/21 13:37:59, stuartmorgan wrote:
> s/google/loadButton/

Done.

https://codereview.chromium.org/1125293004/diff/60001/ios/crnet/crnet_environ...
File ios/crnet/crnet_environment.h (right):

https://codereview.chromium.org/1125293004/diff/60001/ios/crnet/crnet_environ...
ios/crnet/crnet_environment.h:5: #ifndef CRNET_ENVIRONMENT_H_
On 2015/05/21 13:37:59, stuartmorgan wrote:
> Oops, the guard should be IOS_CRNET_CRNET_ENVIRONMENT_H_
> (Remember to fix the #endif comment too)

Done.

[Elly Fong-Jones, 2015-05-21 15:43:00]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2015-05-21 15:43:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
stuartmorgan@chromium.org
Link to the patchset: https://codereview.chromium.org/1125293004/#ps80001
(title: "Fix last nits")

[commit-bot: I haz the power, 2015-05-21 15:43:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1125293004/80001

[commit-bot: I haz the power, 2015-05-21 15:53:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-21 15:53:18]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Elly Fong-Jones, 2015-05-21 17:39:04]

ellyjones@chromium.org changed reviewers:
+ davidben@chromium.org, mmenke@chromium.org, sdefresne@chromium.org

[Elly Fong-Jones, 2015-05-21 17:39:39]

Adding OWNERS reviewers for new deps, PTAL:

davidben@: crypto/nss_util.h dependency
mmenke@: net/ dependency
sdefresne@: components/webp_transcode/ dependency

[mmenke, 2015-05-21 17:50:34]

On 2015/05/21 17:39:39, Elly Jones wrote:
> Adding OWNERS reviewers for new deps, PTAL:
> 
> davidben@: crypto/nss_util.h dependency
> mmenke@: net/ dependency
> sdefresne@: components/webp_transcode/ dependency

net/ dependency LGTM

[sdefresne, 2015-05-21 18:02:23]

components/webp_transcode/ dependency LGTM

[davidben, 2015-05-21 18:03:56]

DEPS lgtm

[Elly Fong-Jones, 2015-05-21 18:05:06]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2015-05-21 18:06:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1125293004/80001

[commit-bot: I haz the power, 2015-05-21 18:13:04]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-21 18:14:04]

Patchset 5 (id:??) landed as
https://crrev.com/a7ce8df915247cafcd8a0d27090c15c293b4fc51
Cr-Commit-Position: refs/heads/master@{#330952}