Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1125283009: Run nacltest steps in mojob.py test (on linux) (Closed)

Created:
5 years, 7 months ago by jamesr
Modified:
5 years, 7 months ago
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, viettrungluu
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Run nacltest steps in mojob.py test (on linux) On my linux z620 in debug mode this increases test time from 55s -> 1m5 which is pretty negligible. This code already builds by default on all linux builds. Also removes a stale dart-specific section. We run the dart tests by default now and don't have a separate test list. R=ncbray@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1be4f5431fefbf4ac9d8af9cdab7dcf6f882d620

Patch Set 1 #

Total comments: 1

Patch Set 2 : exclude asan #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -35 lines) Patch
M mojo/tools/data/apptests View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/tools/get_test_list.py View 1 2 chunks +14 lines, -29 lines 0 comments Download
M mojo/tools/mojob.py View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jamesr
5 years, 7 months ago (2015-05-12 23:17:40 UTC) #1
jamesr
I'd like to do this, unhook the NaCl bots in the master config | change ...
5 years, 7 months ago (2015-05-12 23:18:49 UTC) #2
jamesr
5 years, 7 months ago (2015-05-12 23:31:15 UTC) #3
Nick Bray (chromium)
LGTM, but mention in the commit message why you're removing the dart tests, or don't ...
5 years, 7 months ago (2015-05-12 23:45:36 UTC) #4
Nick Bray (chromium)
Ah, except for ASAN. :/
5 years, 7 months ago (2015-05-12 23:46:11 UTC) #5
jamesr
On 2015/05/12 23:46:11, Nick Bray (chromium) wrote: > Ah, except for ASAN. :/ Ah shit, ...
5 years, 7 months ago (2015-05-12 23:47:32 UTC) #6
jamesr
OK, let's see if this makes the bots happier. Updated the description to clarify the ...
5 years, 7 months ago (2015-05-12 23:49:26 UTC) #7
jamesr
5 years, 7 months ago (2015-05-12 23:57:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1be4f5431fefbf4ac9d8af9cdab7dcf6f882d620 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698