Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1125283005: Only discard for XP dstCopies if we have a coverage value. (Closed)

Created:
5 years, 7 months ago by egdaniel
Modified:
5 years, 7 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org, Chris Dalton
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Only discard for XP dstCopies if we have a coverage value. TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/c19cdc254cc08f334b00c3b9fdb703818c8ca681

Patch Set 1 #

Patch Set 2 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -69 lines) Patch
M include/gpu/GrXferProcessor.h View 5 chunks +20 lines, -5 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/GrXferProcessor.cpp View 2 chunks +20 lines, -1 line 0 comments Download
M src/gpu/effects/GrCoverageSetOpXP.cpp View 2 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 9 chunks +11 lines, -17 lines 0 comments Download
M src/gpu/effects/GrDisableColorXP.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 3 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/gl/GrGLXferProcessor.cpp View 1 1 chunk +8 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
egdaniel
This fixes the bugs introduced to our bledning when I disabled the adv blend mode ...
5 years, 7 months ago (2015-05-10 15:33:16 UTC) #2
joshualitt
On 2015/05/10 15:33:16, egdaniel wrote: > This fixes the bugs introduced to our bledning when ...
5 years, 7 months ago (2015-05-10 15:36:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125283005/20001
5 years, 7 months ago (2015-05-10 15:38:26 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-10 15:45:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/c19cdc254cc08f334b00c3b9fdb703818c8ca681

Powered by Google App Engine
This is Rietveld 408576698