go/src/infra/monitoring/analyzer/test_failures_test.go - Issue 1125263004: dispatcher: fix test result parsing, build ranges for failure alerts, other fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: go/src/infra/monitoring/analyzer/test_failures_test.go

Issue 1125263004: dispatcher: fix test result parsing, build ranges for failure alerts, other fixes (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: added comments, some bounds/type assertion checks Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « go/src/infra/monitoring/analyzer/test_failures.go ('k') | go/src/infra/monitoring/dispatcher/dispatcher.go » ('j') | go/src/infra/monitoring/messages/alerts.go » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: go/src/infra/monitoring/analyzer/test_failures_test.go

diff --git a/go/src/infra/monitoring/analyzer/test_failures_test.go b/go/src/infra/monitoring/analyzer/test_failures_test.go

index 8ab1afd111a722057910d61cbb854f3d7f4f8b47..7a61e37911fd1c69fcb99fb53e57a4bfed9b000b 100644

--- a/go/src/infra/monitoring/analyzer/test_failures_test.go

+++ b/go/src/infra/monitoring/analyzer/test_failures_test.go

@@ -43,10 +43,10 @@ func TestTestStepFailureAlerts(t *testing.T) {

testResults: &messages.TestResults{

- Tests: map[string]messages.TestResult{

- "test_a": messages.TestResult{

- Expected: "PASS",

- Actual: "FAIL",

+ Tests: map[string]interface{}{

+ "test_a": map[string]interface{}{

+ "expected": "PASS",

+ "actual": "FAIL",