go/src/infra/monitoring/messages/alerts.go - Issue 1125263004: dispatcher: fix test result parsing, build ranges for failure alerts, other fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: go/src/infra/monitoring/messages/alerts.go

Issue 1125263004: dispatcher: fix test result parsing, build ranges for failure alerts, other fixes (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: fixed comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« go/src/infra/monitoring/analyzer/analyzer.go ('K') | « go/src/infra/monitoring/dispatcher/dispatcher.go ('k') | go/src/infra/monitoring/messages/gatekeeper.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: go/src/infra/monitoring/messages/alerts.go

diff --git a/go/src/infra/monitoring/messages/alerts.go b/go/src/infra/monitoring/messages/alerts.go

index c9dcdc1bf91c1c118beaea5c7f2b8974a35387e1..9fa0062cf0865a3ef9709062c9a4f52ec684bca9 100644

--- a/go/src/infra/monitoring/messages/alerts.go

+++ b/go/src/infra/monitoring/messages/alerts.go

@@ -84,10 +84,12 @@ type BuildFailure struct {

// AlertedBuilder represents an individual builder.

type AlertedBuilder struct {

- Name string

- URL string

- FirstFailure EpochTime `json:"first_failure"`

- LatestFailure EpochTime `json:"latest_failure"`

+ Name string

+ URL string

+ // Build number of first failure.

Vadim Sh. 2015/05/06 21:40:19 nit: FirstFailure is build number ... same for La

seanmccullough 2015/05/06 22:16:20 Done.

+ FirstFailure int64 `json:"first_failure"`

+ // Build number of latest failure.

+ LatestFailure int64 `json:"latest_failure"`

}

// Reason contains information about why the Alert was triggered.