Issue 1125233002: DM: use SkFunction to make required argument type clearer.

Issue 1125233002: DM: use SkFunction to make required argument type clearer. (Closed)

Created:
5 years, 7 months ago by mtklein_C

Modified:
5 years, 7 months ago

Reviewers:
mtklein, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

DM: use SkFunction to make required argument type clearer. Previously it was hard to tell that DrawFn took an SkCanvas* and returned an Error. Now it's clear from the type. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e44b5084d86772727826e65b8e95e17dc53ee977

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	dm/DMSrcSink.cpp	View		2 chunks	+6 lines, -6 lines	0 comments	Download

Total messages: 10 (4 generated)

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125233002/1

5 years, 7 months ago (2015-05-06 16:00:32 UTC) #4

commit-bot: I haz the power

Dry run: This issue passed the CQ dry run.

5 years, 7 months ago (2015-05-06 16:06:26 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125233002/1

5 years, 7 months ago (2015-05-07 17:46:52 UTC) #9

commit-bot: I haz the power

5 years, 7 months ago (2015-05-07 17:53:40 UTC) #10

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e44b5084d86772727826e65b8e95e17dc53ee977