Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1125213007: Move command line handling out of test runner (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move command line handling out of test runner BUG=478250 R=mkwst@chromium.org Committed: https://crrev.com/80b0417372aa529078fc7e1fdea6e0594831dc68 Cr-Commit-Position: refs/heads/master@{#329988}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M content/shell/renderer/layout_test/layout_test_render_process_observer.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_interfaces.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-14 05:49:40 UTC) #1
Mike West
On 2015/05/14 at 05:49:40, jochen wrote: > Conceptually LGTM. Looks like the bots are unhappy ...
5 years, 7 months ago (2015-05-14 09:26:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125213007/10003
5 years, 7 months ago (2015-05-14 23:45:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:10003)
5 years, 7 months ago (2015-05-15 00:20:30 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 00:21:27 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/80b0417372aa529078fc7e1fdea6e0594831dc68
Cr-Commit-Position: refs/heads/master@{#329988}

Powered by Google App Engine
This is Rietveld 408576698