Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1125193004: Simplify accelerated paint and remove windows CanvasSkiaPaint (Closed)

Created:
5 years, 7 months ago by jbauman
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tdanderson+views_chromium.org, tfarina, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify accelerated paint and remove windows CanvasSkiaPaint We always draw window contents using a compositor, so we can remove the windows desktop aura code that handles GDI painting. TBR=sky@chromium.org Committed: https://crrev.com/232319d6b24f3440c8be9d50b2e726c0f5edd2ce Cr-Commit-Position: refs/heads/master@{#329231}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -249 lines) Patch
M content/browser/compositor/software_output_device_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gfx/canvas.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D ui/gfx/canvas_paint_win.h View 1 chunk +0 lines, -76 lines 0 comments Download
D ui/gfx/canvas_paint_win.cc View 1 chunk +0 lines, -70 lines 0 comments Download
M ui/gfx/canvas_skia_paint.h View 1 chunk +1 line, -3 lines 0 comments Download
M ui/gfx/gfx.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +2 lines, -7 lines 0 comments Download
M ui/views/widget/native_widget_delegate.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 5 chunks +3 lines, -61 lines 0 comments Download
M ui/views/win/hwnd_message_handler_delegate.h View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125193004/1
5 years, 7 months ago (2015-05-08 20:26:21 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/64076)
5 years, 7 months ago (2015-05-09 00:57:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125193004/1
5 years, 7 months ago (2015-05-09 01:25:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
5 years, 7 months ago (2015-05-09 05:41:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125193004/1
5 years, 7 months ago (2015-05-10 08:22:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/9082)
5 years, 7 months ago (2015-05-10 12:26:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125193004/1
5 years, 7 months ago (2015-05-11 18:05:23 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/70639)
5 years, 7 months ago (2015-05-11 19:21:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125193004/1
5 years, 7 months ago (2015-05-11 19:57:17 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/70680)
5 years, 7 months ago (2015-05-11 20:04:31 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125193004/1
5 years, 7 months ago (2015-05-11 20:43:44 UTC) #22
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 21:09:33 UTC) #23
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 21:11:27 UTC) #24
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/232319d6b24f3440c8be9d50b2e726c0f5edd2ce
Cr-Commit-Position: refs/heads/master@{#329231}

Powered by Google App Engine
This is Rietveld 408576698