Index: src/arm/full-codegen-arm.cc |
diff --git a/src/arm/full-codegen-arm.cc b/src/arm/full-codegen-arm.cc |
index e6a19a478c8aa093c35e3bee01ec1e4ac605d688..9d626a6a47d3d1258ccd6da4c28e3e952e5e49ff 100644 |
--- a/src/arm/full-codegen-arm.cc |
+++ b/src/arm/full-codegen-arm.cc |
@@ -1893,8 +1893,11 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) { |
// Emit code to evaluate all the non-constant subexpressions and to store |
// them into the newly cloned array. |
- for (int i = 0; i < length; i++) { |
- Expression* subexpr = subexprs->at(i); |
+ int array_index = 0; |
+ for (; array_index < length; array_index++) { |
+ Expression* subexpr = subexprs->at(array_index); |
+ if (subexpr->IsSpread()) break; |
+ |
// If the subexpression is a literal or a simple materialized literal it |
// is already set in the cloned array. |
if (CompileTimeValue::IsCompileTimeValue(subexpr)) continue; |
@@ -1907,7 +1910,7 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) { |
VisitForAccumulatorValue(subexpr); |
if (has_fast_elements) { |
- int offset = FixedArray::kHeaderSize + (i * kPointerSize); |
+ int offset = FixedArray::kHeaderSize + (array_index * kPointerSize); |
__ ldr(r6, MemOperand(sp, kPointerSize)); // Copy of array literal. |
__ ldr(r1, FieldMemOperand(r6, JSObject::kElementsOffset)); |
__ str(result_register(), FieldMemOperand(r1, offset)); |
@@ -1916,12 +1919,37 @@ void FullCodeGenerator::VisitArrayLiteral(ArrayLiteral* expr) { |
kLRHasBeenSaved, kDontSaveFPRegs, |
EMIT_REMEMBERED_SET, INLINE_SMI_CHECK); |
} else { |
- __ mov(r3, Operand(Smi::FromInt(i))); |
+ __ mov(r3, Operand(Smi::FromInt(array_index))); |
StoreArrayLiteralElementStub stub(isolate()); |
__ CallStub(&stub); |
} |
- PrepareForBailoutForId(expr->GetIdForElement(i), NO_REGISTERS); |
+ PrepareForBailoutForId(expr->GetIdForElement(array_index), NO_REGISTERS); |
+ } |
+ |
+ // In case the array literal contains spread expressions it has two parts. The |
+ // first part is the "static" array which has a literal index is handled |
+ // above. The second part is the part after the first spread expression |
+ // (inclusive) and these elements gets appended to the array. Note that the |
+ // number elements an iterable produces is unknown ahead of time. |
+ if (array_index < length && result_saved) { |
+ __ pop(); // literal index |
+ __ Pop(r0); |
+ result_saved = false; |
+ } |
+ for (; array_index < length; array_index++) { |
+ Expression* subexpr = subexprs->at(array_index); |
+ |
+ __ Push(r0); |
+ if (subexpr->IsSpread()) { |
+ VisitForStackValue(subexpr->AsSpread()->expression()); |
+ __ InvokeBuiltin(Builtins::CONCAT_ITERABLE_TO_ARRAY, CALL_FUNCTION); |
+ } else { |
+ VisitForStackValue(subexpr); |
+ __ CallRuntime(Runtime::kAppendElement, 2); |
+ } |
+ |
+ PrepareForBailoutForId(expr->GetIdForElement(array_index), NO_REGISTERS); |
} |
if (result_saved) { |