Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1125173006: Disable user gesture checking for all autofill browser tests. (Closed)

Created:
5 years, 7 months ago by please use gerrit instead
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang, Evan Stade
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, glider+watch_chromium.org, rouslan+autofillwatch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable user gesture checking for all autofill browser tests. When drmemory_full runs, the browser tests are slowed down enough to timeout the user gesture indicator, which prevents autofill from processing the input and passing the browser test. The fix is to disable user gesture checking for all autofill browser tests except AutofillRendererTest.IgnoreNonUserGestureTextFieldChanges. BUG=484910 Committed: https://crrev.com/1570b4eea7e48eb29804542780b5bd41aab7a0a2 Cr-Commit-Position: refs/heads/master@{#330261}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -11 lines) Patch
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 1 5 chunks +44 lines, -5 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 2 chunks +5 lines, -1 line 0 comments Download
M tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory.txt View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
please use gerrit instead
Evan, PTAL 3 files: chrome/renderer/autofill/autofill_renderer_browsertest.cc components/autofill/content/renderer/autofill_agent.h components/autofill/content/renderer/autofill_agent.cc Lei, PTAL 3 files: chrome/test/base/chrome_render_view_test.h chrome/test/base/chrome_render_view_test.cc tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory.txt
5 years, 7 months ago (2015-05-14 21:39:51 UTC) #2
Lei Zhang
https://codereview.chromium.org/1125173006/diff/1/chrome/test/base/chrome_render_view_test.cc File chrome/test/base/chrome_render_view_test.cc (right): https://codereview.chromium.org/1125173006/diff/1/chrome/test/base/chrome_render_view_test.cc#newcode40 chrome/test/base/chrome_render_view_test.cc:40: using autofill::AutofillAgent; these can be outside the anonymous namespace ...
5 years, 7 months ago (2015-05-15 22:49:14 UTC) #3
Evan Stade
my files lgtm
5 years, 7 months ago (2015-05-15 23:32:00 UTC) #4
please use gerrit instead
Lei, PTAL Patch Set 2. https://codereview.chromium.org/1125173006/diff/1/chrome/test/base/chrome_render_view_test.cc File chrome/test/base/chrome_render_view_test.cc (right): https://codereview.chromium.org/1125173006/diff/1/chrome/test/base/chrome_render_view_test.cc#newcode40 chrome/test/base/chrome_render_view_test.cc:40: using autofill::AutofillAgent; On 2015/05/15 ...
5 years, 7 months ago (2015-05-16 00:08:09 UTC) #5
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-16 00:13:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125173006/20001
5 years, 7 months ago (2015-05-16 00:15:49 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-16 01:28:31 UTC) #10
aurimas (slooooooooow)
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1140013004/ by aurimas@chromium.org. ...
5 years, 7 months ago (2015-05-16 03:02:46 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:30:36 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1570b4eea7e48eb29804542780b5bd41aab7a0a2
Cr-Commit-Position: refs/heads/master@{#330261}

Powered by Google App Engine
This is Rietveld 408576698