Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1125153008: [microdump] Add build fingerprint and product info metadata. (Closed)

Created:
5 years, 7 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
google-breakpad-dev_googlegroups.com, Mark Mentovai, mmandlis
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[microdump] Add build fingerprint and product info metadata. This is to add build fingerprint and product name/version to microdumps. Conversely to what happens in the case of minidumps with MIME fields, due to the nature of minidumps, extra metadata cannot be reliably injected after the dump is completed. This CL adds the plumbing to inject two optional fields plus the corresponding tests. BUG=chromium:410294 R=thestig@chromium.org Committed: https://code.google.com/p/google-breakpad/source/detail?r=1456

Patch Set 1 : This is identical to https://breakpad.appspot.com/9794002/ PS1 #

Patch Set 2 : Addressing changes from https://breakpad.appspot.com/9794002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -50 lines) Patch
M src/client/linux/handler/exception_handler.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M src/client/linux/handler/minidump_descriptor.h View 1 4 chunks +36 lines, -4 lines 0 comments Download
M src/client/linux/handler/minidump_descriptor.cc View 3 chunks +16 lines, -1 line 0 comments Download
M src/client/linux/microdump_writer/microdump_writer.h View 1 1 chunk +7 lines, -1 line 0 comments Download
M src/client/linux/microdump_writer/microdump_writer.cc View 8 chunks +41 lines, -15 lines 0 comments Download
M src/client/linux/microdump_writer/microdump_writer_unittest.cc View 1 4 chunks +56 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Primiano Tucci (use gerrit)
Lei, I'm sorry for the huge delay of this response, I got derailed in the ...
5 years, 7 months ago (2015-05-14 15:23:18 UTC) #2
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-14 19:09:56 UTC) #3
Primiano Tucci (use gerrit)
5 years, 7 months ago (2015-05-15 08:43:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 1456 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698