Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1125143004: DevTools: [PrettyPrint] support template literals in pretty-printing (Closed)

Created:
5 years, 7 months ago by lushnikov
Modified:
5 years, 7 months ago
Reviewers:
sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: [PrettyPrint] support template literals in pretty-printing Add support for template literals and tagged template expressions. BUG=437476 R=pfeldman_slow, sergeyv Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195358

Patch Set 1 #

Patch Set 2 : fix test #

Total comments: 2

Patch Set 3 : address comments #

Messages

Total messages: 7 (2 generated)
lushnikov
ptal
5 years, 7 months ago (2015-05-13 18:50:35 UTC) #1
sergeyv
lgtm https://codereview.chromium.org/1125143004/diff/20001/Source/devtools/front_end/script_formatter_worker/ESTreeWalker.js File Source/devtools/front_end/script_formatter_worker/ESTreeWalker.js (right): https://codereview.chromium.org/1125143004/diff/20001/Source/devtools/front_end/script_formatter_worker/ESTreeWalker.js#newcode50 Source/devtools/front_end/script_formatter_worker/ESTreeWalker.js:50: this._innerWalk(templateLiteral.quasis[expressionsLength - 1], templateLiteral); expressionLength
5 years, 7 months ago (2015-05-14 13:01:17 UTC) #2
lushnikov
https://codereview.chromium.org/1125143004/diff/20001/Source/devtools/front_end/script_formatter_worker/ESTreeWalker.js File Source/devtools/front_end/script_formatter_worker/ESTreeWalker.js (right): https://codereview.chromium.org/1125143004/diff/20001/Source/devtools/front_end/script_formatter_worker/ESTreeWalker.js#newcode50 Source/devtools/front_end/script_formatter_worker/ESTreeWalker.js:50: this._innerWalk(templateLiteral.quasis[expressionsLength - 1], templateLiteral); Nice catch, thanks!
5 years, 7 months ago (2015-05-14 13:07:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125143004/40001
5 years, 7 months ago (2015-05-14 14:38:29 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 16:04:09 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195358

Powered by Google App Engine
This is Rietveld 408576698