Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1125123008: Files.app: Use quotaBytesUsedAggregate to know the actual available space. (Closed)

Created:
5 years, 7 months ago by fukino
Modified:
5 years, 7 months ago
Reviewers:
mtomasz, kinaba
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Use quotaBytesUsedAggregate to know the actual available space. We need to use quotaBytesUsedAggregate to know the actual available space, because the current quotaBytesUsed returns usage in only Google Drive (doesn't include Gmail, G+ Photos, etc...). https://developers.google.com/drive/v2/reference/about#resource BUG=483058 TEST=run unit_tests Committed: https://crrev.com/fa39c6524a482ae3dc75773dbc4e88f4ed9e8fbf Cr-Commit-Position: refs/heads/master@{#329330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -23 lines) Patch
M chrome/browser/chromeos/drive/file_system.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/drive/drive_api_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/drive/about.json View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/drive_api_parser.h View 3 chunks +6 lines, -4 lines 0 comments Download
M google_apis/drive/drive_api_parser.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M google_apis/drive/drive_api_parser_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 4 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
fukino
Could you take a look? Thanks!
5 years, 7 months ago (2015-05-11 06:02:16 UTC) #2
mtomasz
lgtm
5 years, 7 months ago (2015-05-11 06:11:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125123008/1
5 years, 7 months ago (2015-05-11 08:29:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/62551)
5 years, 7 months ago (2015-05-11 08:40:30 UTC) #7
fukino
kinaba@, could you take a look at the followings? google_apis/drive/* chrome/browser/ui/webui/chromeos/drive_internals_ui.cc Thanks!
5 years, 7 months ago (2015-05-12 00:42:38 UTC) #9
kinaba
lgtm. thanks!
5 years, 7 months ago (2015-05-12 01:28:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125123008/1
5 years, 7 months ago (2015-05-12 01:40:24 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 02:46:21 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 02:47:04 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa39c6524a482ae3dc75773dbc4e88f4ed9e8fbf
Cr-Commit-Position: refs/heads/master@{#329330}

Powered by Google App Engine
This is Rietveld 408576698