Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1125113003: Revert of [V8] Reland https://codereview.chromium.org/1100993003/ (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
Reviewers:
kozy, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [V8] Reland https://codereview.chromium.org/1100993003/ (patchset #1 id:1 of https://codereview.chromium.org/1121833003/) Reason for revert: [Sheriff] Speculative revert for breaking layout tests - will reland if it doesn't help: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/3178 Original issue's description: > [V8] Reland https://codereview.chromium.org/1100993003/ > > Chromium tests were prepared in https://codereview.chromium.org/1118743003/ > Blink tests in https://codereview.chromium.org/1115193002/ > > LOG=Y > BUG=chromium:480652 > R=yangguo@chromium.org > > Committed: https://crrev.com/19b62e211d1829108e5c85c5043dd755afa17178 > Cr-Commit-Position: refs/heads/master@{#28229} TBR=yangguo@chromium.org,kozyatinskiy@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:480652 Committed: https://crrev.com/4a2b4cdbf8a2cd18d5bb8bb85aa6fee59e4ea3ca Cr-Commit-Position: refs/heads/master@{#28247}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M src/scanner.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [V8] Reland https://codereview.chromium.org/1100993003/
5 years, 7 months ago (2015-05-06 06:59:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125113003/1
5 years, 7 months ago (2015-05-06 06:59:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 06:59:39 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 06:59:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a2b4cdbf8a2cd18d5bb8bb85aa6fee59e4ea3ca
Cr-Commit-Position: refs/heads/master@{#28247}

Powered by Google App Engine
This is Rietveld 408576698