Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 1125113002: Remove the unused parts of PPB_PDF (Closed)

Created:
5 years, 7 months ago by raymes
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang, Sam McNally, jam
CC:
chromium-reviews, tfarina, dcheng, Paweł Hajdan Jr., chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pdf-delete-pdf
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the unused parts of PPB_PDF These parts were only used by the in-process viewer. BUG=303491 TBR=jam@chromium.org for components/resources/ Committed: https://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a Cr-Commit-Position: refs/heads/master@{#328695}

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -1067 lines) Patch
D chrome/browser/ui/cocoa/pdf_password_dialog_cocoa.mm View 1 chunk +0 lines, -141 lines 0 comments Download
M chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D chrome/browser/ui/views/pdf_password_dialog.cc View 1 chunk +0 lines, -132 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/renderer/pepper/chrome_pdf_print_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/pepper/pepper_flash_renderer_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/pdf.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/pdf/browser/pdf_web_contents_helper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/pdf/browser/pdf_web_contents_helper.cc View 2 chunks +0 lines, -22 lines 0 comments Download
M components/pdf/browser/pdf_web_contents_helper_client.h View 1 2 2 chunks +0 lines, -9 lines 0 comments Download
M components/pdf/common/pdf_messages.h View 1 chunk +0 lines, -5 lines 0 comments Download
M components/pdf/renderer/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/pdf/renderer/pdf_resource_util.h View 1 chunk +0 lines, -6 lines 0 comments Download
M components/pdf/renderer/pdf_resource_util.cc View 1 2 2 chunks +1 line, -79 lines 0 comments Download
M components/pdf/renderer/pepper_pdf_host.h View 2 chunks +23 lines, -12 lines 0 comments Download
M components/pdf/renderer/pepper_pdf_host.cc View 1 7 chunks +24 lines, -115 lines 0 comments Download
D components/pdf/renderer/ppb_pdf_impl.h View 1 chunk +0 lines, -46 lines 0 comments Download
D components/pdf/renderer/ppb_pdf_impl.cc View 1 chunk +0 lines, -393 lines 0 comments Download
M components/resources/components_scaled_resources.grd View 1 chunk +0 lines, -1 line 0 comments Download
D components/resources/default_100_percent/pdf/pan_icon.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_ftp.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_ftp_hover.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_ftp_pressed.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_ftw.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_ftw_hover.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_ftw_pressed.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_print.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_print_disabled.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_print_hover.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_print_pressed.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_save.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_save_hover.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_save_pressed.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_zoomin.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_zoomin_end.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_zoomin_end_hover.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_zoomin_end_pressed.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_zoomin_hover.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_zoomin_pressed.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_zoomout.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_zoomout_hover.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_button_zoomout_pressed.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_dropshadow.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_page_indicator_background.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_progress_0.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_progress_1.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_progress_2.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_progress_3.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_progress_4.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_progress_5.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_progress_6.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_progress_7.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_progress_8.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_progress_background.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_thumbnail_0.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_thumbnail_1.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_thumbnail_2.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_thumbnail_3.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_thumbnail_4.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_thumbnail_5.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_thumbnail_6.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_thumbnail_7.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_thumbnail_8.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_thumbnail_9.png View Binary file 0 comments Download
D components/resources/default_100_percent/pdf/pdf_thumbnail_num_background.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pan_icon.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_ftp.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_ftp_hover.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_ftp_pressed.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_ftw.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_ftw_hover.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_ftw_pressed.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_print.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_print_disabled.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_print_hover.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_print_pressed.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_save.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_save_hover.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_save_pressed.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_zoomin.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_zoomin_end.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_zoomin_end_hover.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_zoomin_end_pressed.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_zoomin_hover.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_zoomin_pressed.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_zoomout.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_zoomout_hover.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_button_zoomout_pressed.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_dropshadow.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_page_indicator_background.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_progress_0.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_progress_1.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_progress_2.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_progress_3.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_progress_4.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_progress_5.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_progress_6.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_progress_7.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_progress_8.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_progress_background.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_thumbnail_0.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_thumbnail_1.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_thumbnail_2.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_thumbnail_3.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_thumbnail_4.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_thumbnail_5.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_thumbnail_6.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_thumbnail_7.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_thumbnail_8.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_thumbnail_9.png View Binary file 0 comments Download
D components/resources/default_200_percent/pdf/pdf_thumbnail_num_background.png View Binary file 0 comments Download
D components/resources/pdf_scaled_resources.grdp View 1 chunk +0 lines, -51 lines 0 comments Download
M ppapi/tests/test_pdf.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/tests/test_pdf.cc View 1 2 3 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
raymes
Take your time reviewing this. There are a ton of files but most of them ...
5 years, 7 months ago (2015-05-06 06:21:28 UTC) #2
Sam McNally
LGTM https://codereview.chromium.org/1125113002/diff/20001/components/pdf/browser/pdf_web_contents_helper_client.h File components/pdf/browser/pdf_web_contents_helper_client.h (left): https://codereview.chromium.org/1125113002/diff/20001/components/pdf/browser/pdf_web_contents_helper_client.h#oldcode20 components/pdf/browser/pdf_web_contents_helper_client.h:20: PasswordDialogClosedCallback; Remove. https://codereview.chromium.org/1125113002/diff/20001/components/pdf/renderer/pdf_resource_util.cc File components/pdf/renderer/pdf_resource_util.cc (left): https://codereview.chromium.org/1125113002/diff/20001/components/pdf/renderer/pdf_resource_util.cc#oldcode110 components/pdf/renderer/pdf_resource_util.cc:110: ...
5 years, 7 months ago (2015-05-06 07:16:45 UTC) #3
raymes
+thestig for chrome/ OWNERS https://codereview.chromium.org/1125113002/diff/20001/components/pdf/browser/pdf_web_contents_helper_client.h File components/pdf/browser/pdf_web_contents_helper_client.h (left): https://codereview.chromium.org/1125113002/diff/20001/components/pdf/browser/pdf_web_contents_helper_client.h#oldcode20 components/pdf/browser/pdf_web_contents_helper_client.h:20: PasswordDialogClosedCallback; On 2015/05/06 07:16:45, Sam ...
5 years, 7 months ago (2015-05-07 00:49:40 UTC) #5
Lei Zhang
chrome/ lgtm
5 years, 7 months ago (2015-05-07 01:06:40 UTC) #6
raymes
TBR=jam@chromium.org for components/resources/
5 years, 7 months ago (2015-05-07 01:40:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125113002/40001
5 years, 7 months ago (2015-05-07 01:41:05 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/34937)
5 years, 7 months ago (2015-05-07 01:59:16 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125113002/60001
5 years, 7 months ago (2015-05-07 02:05:50 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-07 03:44:47 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 03:46:26 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ec40c91c3f90649a4e7a29a459839d1fb5a46e1a
Cr-Commit-Position: refs/heads/master@{#328695}

Powered by Google App Engine
This is Rietveld 408576698