Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 1125103003: Fix V8 extras js2c pipeline (Closed)

Created:
5 years, 7 months ago by domenic
Modified:
5 years, 7 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix V8 extras js2c pipeline 570fca61 introduced a regression that caused minification etc. to be applied to V8 extras. R=yangguo@chromium.org BUG= Committed: https://crrev.com/f344e524d823c810067d8fb98e245710b1d232d0 Cr-Commit-Position: refs/heads/master@{#28427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/js2c.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
domenic
5 years, 7 months ago (2015-05-13 18:33:00 UTC) #1
Yang
lgtm.
5 years, 7 months ago (2015-05-15 10:40:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125103003/1
5 years, 7 months ago (2015-05-15 15:08:25 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 15:33:00 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 15:33:15 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f344e524d823c810067d8fb98e245710b1d232d0
Cr-Commit-Position: refs/heads/master@{#28427}

Powered by Google App Engine
This is Rietveld 408576698