Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1125103002: Remove the in-process PDF viewer from pdf/ (Closed)

Created:
5 years, 7 months ago by raymes
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang, Sam McNally
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove-in-process-instance
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the in-process PDF viewer from pdf/ BUG=303491 Committed: https://crrev.com/a865c1dc8cdb0b0d0e5efab76623f1f5c23f6119 Cr-Commit-Position: refs/heads/master@{#328498}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5404 lines) Patch
M pdf/BUILD.gn View 2 chunks +0 lines, -18 lines 0 comments Download
D pdf/button.h View 1 chunk +0 lines, -71 lines 0 comments Download
D pdf/button.cc View 1 chunk +0 lines, -179 lines 0 comments Download
D pdf/control.h View 1 chunk +0 lines, -77 lines 0 comments Download
D pdf/control.cc View 1 chunk +0 lines, -117 lines 0 comments Download
D pdf/fading_control.h View 1 chunk +0 lines, -32 lines 0 comments Download
D pdf/fading_control.cc View 1 chunk +0 lines, -75 lines 0 comments Download
D pdf/fading_controls.h View 1 chunk +0 lines, -84 lines 0 comments Download
D pdf/fading_controls.cc View 1 chunk +0 lines, -316 lines 0 comments Download
D pdf/instance.h View 1 chunk +0 lines, -539 lines 0 comments Download
D pdf/instance.cc View 1 chunk +0 lines, -2833 lines 0 comments Download
D pdf/number_image_generator.h View 1 chunk +0 lines, -37 lines 0 comments Download
D pdf/number_image_generator.cc View 1 chunk +0 lines, -81 lines 0 comments Download
D pdf/page_indicator.h View 1 chunk +0 lines, -72 lines 0 comments Download
D pdf/page_indicator.cc View 1 chunk +0 lines, -127 lines 0 comments Download
M pdf/pdf.cc View 2 chunks +1 line, -4 lines 0 comments Download
M pdf/pdf.gyp View 1 chunk +0 lines, -18 lines 0 comments Download
M pdf/preview_mode_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
D pdf/progress_control.h View 1 chunk +0 lines, -72 lines 0 comments Download
D pdf/progress_control.cc View 1 chunk +0 lines, -283 lines 0 comments Download
D pdf/thumbnail_control.h View 1 chunk +0 lines, -67 lines 0 comments Download
D pdf/thumbnail_control.cc View 1 chunk +0 lines, -301 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
raymes
There are is a bunch of other code which can also be removed but I ...
5 years, 7 months ago (2015-05-06 05:47:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125103002/1
5 years, 7 months ago (2015-05-06 05:49:25 UTC) #4
Sam McNally
LGTM
5 years, 7 months ago (2015-05-06 05:56:30 UTC) #5
Lei Zhang
lgtm, yay!
5 years, 7 months ago (2015-05-06 06:33:36 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-06 06:47:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125103002/1
5 years, 7 months ago (2015-05-06 07:04:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 07:07:46 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 07:08:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a865c1dc8cdb0b0d0e5efab76623f1f5c23f6119
Cr-Commit-Position: refs/heads/master@{#328498}

Powered by Google App Engine
This is Rietveld 408576698