Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 1125073004: Prevent stack overflow in the serializer/deserializer. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
mvstanton
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Prevent stack overflow in the serializer/deserializer. We keep an eye on the recursion depth. Once it exceeds a limit, we serialize only the object header and size, but defer serializing the object body for after we have unwound the stack. R=mvstanton@chromium.org Committed: https://crrev.com/36b4a498d6614243454d5a182e4946b0dad24f0a Cr-Commit-Position: refs/heads/master@{#28385}

Patch Set 1 #

Patch Set 2 : do not defer allocation site #

Patch Set 3 : fix #

Patch Set 4 : fix assertion, unlink allocation site #

Patch Set 5 : fix uninitialized #

Patch Set 6 : fixed all #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -49 lines) Patch
M src/api.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 1 chunk +6 lines, -5 lines 0 comments Download
M src/snapshot/serialize.h View 1 2 3 4 5 11 chunks +46 lines, -10 lines 0 comments Download
M src/snapshot/serialize.cc View 1 2 3 4 5 21 chunks +117 lines, -30 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 2 3 4 5 4 chunks +41 lines, -3 lines 0 comments Download

Messages

Total messages: 33 (14 generated)
Yang
5 years, 7 months ago (2015-05-12 13:01:14 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125073004/1
5 years, 7 months ago (2015-05-12 13:01:41 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/4099)
5 years, 7 months ago (2015-05-12 13:33:30 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125073004/20001
5 years, 7 months ago (2015-05-12 14:22:25 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/316)
5 years, 7 months ago (2015-05-12 14:25:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125073004/40001
5 years, 7 months ago (2015-05-12 14:31:22 UTC) #11
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-12 14:31:24 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125073004/40001
5 years, 7 months ago (2015-05-12 14:38:33 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/318)
5 years, 7 months ago (2015-05-12 14:44:06 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125073004/60001
5 years, 7 months ago (2015-05-12 18:57:58 UTC) #19
Yang
Michael, I uploaded the 4th patch set to fix the assertion, and to address an ...
5 years, 7 months ago (2015-05-12 19:02:45 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/2504)
5 years, 7 months ago (2015-05-12 19:07:27 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125073004/80001
5 years, 7 months ago (2015-05-12 19:11:00 UTC) #24
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-12 19:36:49 UTC) #26
mvstanton
LGTM. Darn those pesky 'Sites :).
5 years, 7 months ago (2015-05-13 07:27:55 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125073004/100001
5 years, 7 months ago (2015-05-13 09:56:41 UTC) #30
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-13 10:18:40 UTC) #31
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/36b4a498d6614243454d5a182e4946b0dad24f0a Cr-Commit-Position: refs/heads/master@{#28385}
5 years, 7 months ago (2015-05-13 10:18:49 UTC) #32
Michael Achenbach
5 years, 7 months ago (2015-05-14 14:59:01 UTC) #33
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1139113002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks msan:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20s....

Powered by Google App Engine
This is Rietveld 408576698