components/nacl/common/nacl_messages.h - Issue 1125043002: NaCl: Stop sending resource FDs with NaClProcessMsg_Start

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/common/nacl_messages.h

Issue 1125043002: NaCl: Stop sending resource FDs with NaClProcessMsg_Start (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: git rebase master Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/nacl/browser/nacl_process_host.cc ('K') | « components/nacl/browser/nacl_process_host.cc ('k') | components/nacl/common/nacl_types.h » ('j') | components/nacl/loader/nacl_listener.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/nacl/common/nacl_messages.h

diff --git a/components/nacl/common/nacl_messages.h b/components/nacl/common/nacl_messages.h

index 3bdd16e1ddae6b390372eac617675b54d1656214..f07648cd4148cb77509e27d94418b0c7bb8867ba 100644

--- a/components/nacl/common/nacl_messages.h

+++ b/components/nacl/common/nacl_messages.h

@@ -17,7 +17,6 @@

IPC_STRUCT_TRAITS_BEGIN(nacl::NaClStartParams)

IPC_STRUCT_TRAITS_MEMBER(nexe_file)

IPC_STRUCT_TRAITS_MEMBER(nexe_file_path_metadata)

- IPC_STRUCT_TRAITS_MEMBER(prefetched_resource_files)

IPC_STRUCT_TRAITS_MEMBER(imc_bootstrap_handle)

IPC_STRUCT_TRAITS_MEMBER(irt_handle)

#if defined(OS_MACOSX)

@@ -48,6 +47,10 @@ IPC_STRUCT_TRAITS_END()

IPC_MESSAGE_CONTROL1(NaClProcessMsg_Start,

nacl::NaClStartParams /* params */)

+// Sends prefetched resource files to a NaCl loader process.

Mark Seaborn 2015/05/08 00:35:36 Can you document the ordering here? Which message

Yusuke Sato 2015/05/08 15:12:35 Done.

+IPC_MESSAGE_CONTROL1(NaClProcessMsg_SetPrefetchedResource,

Mark Seaborn 2015/05/08 00:35:36 Naming nit: How about "Add" rather than "Set"?

Yusuke Sato 2015/05/08 15:12:35 Done.

+ std::vector<nacl::NaClResourcePrefetchResult>)

#if defined(OS_WIN)

// Tells the NaCl broker to launch a NaCl loader process.

IPC_MESSAGE_CONTROL1(NaClProcessMsg_LaunchLoaderThroughBroker,