Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2217)

Unified Diff: build/config/crypto.gni

Issue 1125033004: Clarify and update GN build flags docs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | build/config/features.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/crypto.gni
diff --git a/build/config/crypto.gni b/build/config/crypto.gni
index 7f090b7a5446d66c6d696d61dc505faca829c1c0..4d42a375bc71e85c8305847deb21e44e5131b2a4 100644
--- a/build/config/crypto.gni
+++ b/build/config/crypto.gni
@@ -6,6 +6,10 @@
#
# TODO(brettw) this should probably be moved to src/crypto or somewhere, and
# the global build dependency on it should be removed.
+#
+# PLEASE TRY TO AVOID ADDING FLAGS TO THIS FILE in cases where grit isn't
+# required. See the declare_args block of BUILDCONFIG.gn for advice on how
+# to set up feature flags.
declare_args() {
# Use OpenSSL instead of NSS. This is used for Android, Mac, NaCl untrusted
« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | build/config/features.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698