Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Side by Side Diff: build/config/features.gni

Issue 1125033004: Clarify and update GN build flags docs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/crypto.gni ('k') | build/config/ui.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains UI-related build flags. It should theoretically be in the 5 # This file contains Chrome-feature-related build flags (see ui.gni for
6 # src/ui directory and only things that depend on the ui module should get the 6 # UI-related ones). These should theoretically be moved to the build files of
7 # definitions. 7 # the features themselves.
8 # 8 #
9 # However, today we have many "bad" dependencies on some of these flags from, 9 # However, today we have many "bad" dependencies on some of these flags from,
10 # e.g. base, so they need to be global. 10 # e.g. base, so they need to be global to match the GYP configuration. Also,
11 # anything that needs a grit define must be in either this file or ui.gni.
11 # 12 #
12 # See also build/config/ui.gni 13 # PLEASE TRY TO AVOID ADDING FLAGS TO THIS FILE in cases where grit isn't
14 # required. See the declare_args block of BUILDCONFIG.gn for advice on how
15 # to set up feature flags.
13 16
14 import("//build/config/chrome_build.gni") 17 import("//build/config/chrome_build.gni")
15 if (is_android) { 18 if (is_android) {
16 import("//build/config/android/config.gni") 19 import("//build/config/android/config.gni")
17 } 20 }
18 21
19 declare_args() { 22 declare_args() {
20 # Multicast DNS. 23 # Multicast DNS.
21 enable_mdns = is_win || is_linux 24 enable_mdns = is_win || is_linux
22 25
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 # TODO(GYP) also require !embedded to enable. 190 # TODO(GYP) also require !embedded to enable.
188 use_gconf = is_linux && !is_chromeos 191 use_gconf = is_linux && !is_chromeos
189 192
190 # Hangout services is an extension that adds extra features to Hangouts. 193 # Hangout services is an extension that adds extra features to Hangouts.
191 # For official GYP builds, this flag is set, it will likely need to be 194 # For official GYP builds, this flag is set, it will likely need to be
192 # parameterized in the future for a similar use. 195 # parameterized in the future for a similar use.
193 enable_hangout_services_extension = false 196 enable_hangout_services_extension = false
194 197
195 # Whether to back up data before sync. 198 # Whether to back up data before sync.
196 enable_pre_sync_backup = is_win || is_mac || (is_linux && !is_chromeos) 199 enable_pre_sync_backup = is_win || is_mac || (is_linux && !is_chromeos)
OLDNEW
« no previous file with comments | « build/config/crypto.gni ('k') | build/config/ui.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698