Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1124993002: Cleanup: Only need one bit (not two) to express flow thread state. (Closed)

Created:
5 years, 7 months ago by mstensho (USE GERRIT)
Modified:
5 years, 7 months ago
Reviewers:
dsinclair
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Cleanup: Only need one bit (not two) to express flow thread state. The InsideOutOfFlowThread / InsideInFlowThread distinction is a relic from the CSS Regions days. Just telling whether we're a descendant of a flow thread or not is enough. R=dsinclair@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194945

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -30 lines) Patch
M Source/core/dom/LayoutTreeBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutFlowThread.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayoutInline.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutObject.h View 7 chunks +10 lines, -18 lines 1 comment Download
M Source/core/layout/LayoutObject.cpp View 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
5 years, 7 months ago (2015-05-05 19:07:12 UTC) #1
mstensho (USE GERRIT)
https://codereview.chromium.org/1124993002/diff/1/Source/core/layout/LayoutObject.h File Source/core/layout/LayoutObject.h (right): https://codereview.chromium.org/1124993002/diff/1/Source/core/layout/LayoutObject.h#newcode1316 Source/core/layout/LayoutObject.h:1316: // 32 bits have been used in the first ...
5 years, 7 months ago (2015-05-05 19:09:09 UTC) #2
dsinclair
lgtm
5 years, 7 months ago (2015-05-05 19:09:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124993002/1
5 years, 7 months ago (2015-05-05 19:09:52 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 22:21:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194945

Powered by Google App Engine
This is Rietveld 408576698