Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: ui/events/keycodes/dom/keycode_converter.h

Issue 1124963003: Remove ui::KeycodeConverter::CodeToNativeKeycode(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x444048-3a-codes
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/event_unittest.cc ('k') | ui/events/keycodes/dom/keycode_converter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/keycodes/dom/keycode_converter.h
diff --git a/ui/events/keycodes/dom/keycode_converter.h b/ui/events/keycodes/dom/keycode_converter.h
index 1f1fed0de350c462339cf3d1035c40e164d12866..fb1ac04112a5af313f6e3213db5458c78a153d39 100644
--- a/ui/events/keycodes/dom/keycode_converter.h
+++ b/ui/events/keycodes/dom/keycode_converter.h
@@ -45,16 +45,9 @@ class KeycodeConverter {
// Return the value that identifies an invalid native keycode.
static int InvalidNativeKeycode();
- // Convert a native (Mac/Win/Linux) keycode into the |code| string.
- // The returned pointer references a static global string.
- static const char* NativeKeycodeToCode(int native_keycode);
-
// Convert a native (Mac/Win/Linux) keycode into a DomCode.
static DomCode NativeKeycodeToDomCode(int native_keycode);
- // Convert a UI Events |code| string value into a native keycode.
- static int CodeToNativeKeycode(const char* code);
-
// Convert a DomCode into a native keycode.
static int DomCodeToNativeKeycode(DomCode code);
@@ -88,13 +81,12 @@ class KeycodeConverter {
// Convert a platform native keycode into an equivalent USB keycode.
static uint32_t NativeKeycodeToUsbKeycode(int native_keycode);
- // Convert a USB keycode into the string with the DOM3 |code| value.
- // The returned pointer references a static global string.
- static const char* UsbKeycodeToCode(uint32_t usb_keycode);
-
// Convert a USB keycode into a DomCode.
static DomCode UsbKeycodeToDomCode(uint32_t usb_keycode);
+ // Convert a DomCode into a USB keycode.
+ static uint32_t DomCodeToUsbKeycode(DomCode dom_code);
+
// Convert a DOM3 Event |code| string into a USB keycode value.
static uint32_t CodeToUsbKeycode(const char* code);
« no previous file with comments | « ui/events/event_unittest.cc ('k') | ui/events/keycodes/dom/keycode_converter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698