ui/events/event_unittest.cc - Issue 1124963003: Remove ui::KeycodeConverter::CodeToNativeKeycode().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/event_unittest.cc

Issue 1124963003: Remove ui::KeycodeConverter::CodeToNativeKeycode(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@x444048-3a-codes

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc ('K') | « content/public/test/browser_test_utils.cc ('k') | ui/events/keycodes/dom4/keycode_converter.h » ('j') | ui/events/keycodes/dom4/keycode_converter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/events/event_unittest.cc

diff --git a/ui/events/event_unittest.cc b/ui/events/event_unittest.cc

index 6d948121be5d22abac0ad06e0fb7b9936beed150..32fbf15c5968352299acf0d1503f36ddfe209049 100644

--- a/ui/events/event_unittest.cc

+++ b/ui/events/event_unittest.cc

@@ -351,7 +351,7 @@ TEST(EventTest, KeyEventCode) {

ASSERT_EQ(kDomCodeForSpace,

ui::KeycodeConverter::CodeStringToDomCode(kCodeForSpace));

Wez 2015/05/05 20:11:48 nit: I don't think this ASSERT really adds anythin

kpschoedel 2015/05/05 20:48:50 Done.

const uint16 kNativeCodeSpace =

- ui::KeycodeConverter::CodeToNativeKeycode(kCodeForSpace);

+ ui::KeycodeConverter::DomCodeToNativeKeycode(kDomCodeForSpace);

ASSERT_NE(ui::KeycodeConverter::InvalidNativeKeycode(), kNativeCodeSpace);

ASSERT_EQ(kNativeCodeSpace,

ui::KeycodeConverter::DomCodeToNativeKeycode(kDomCodeForSpace));

Wez 2015/05/05 20:11:48 This assertion is trivially true now!

kpschoedel 2015/05/05 20:48:50 Done.

@@ -433,8 +433,10 @@ void AdvanceKeyEventTimestamp(MSG& msg) {

#if defined(USE_X11) || defined(OS_WIN)

TEST(EventTest, AutoRepeat) {

- const uint16 kNativeCodeA = ui::KeycodeConverter::CodeToNativeKeycode("KeyA");

- const uint16 kNativeCodeB = ui::KeycodeConverter::CodeToNativeKeycode("KeyB");

+ const uint16 kNativeCodeA =

+ ui::KeycodeConverter::DomCodeToNativeKeycode(DomCode::KEY_A);

+ const uint16 kNativeCodeB =

+ ui::KeycodeConverter::DomCodeToNativeKeycode(DomCode::KEY_B);

#if defined(USE_X11)

ScopedXI2Event native_event_a_pressed;

native_event_a_pressed.InitKeyEvent(ET_KEY_PRESSED, VKEY_A, kNativeCodeA);