Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: device/bluetooth/bluetooth_adapter_chromeos.h

Issue 1124883004: Submission for C++ Readability (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, address final comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_adapter_chromeos.h
diff --git a/device/bluetooth/bluetooth_adapter_chromeos.h b/device/bluetooth/bluetooth_adapter_chromeos.h
index 13942d8c387bd16ea96207c0bf377b2d2cb2fdd2..846a6230c3a9eeeb4e3adbe102093e8652436359 100644
--- a/device/bluetooth/bluetooth_adapter_chromeos.h
+++ b/device/bluetooth/bluetooth_adapter_chromeos.h
@@ -46,6 +46,12 @@ class BluetoothRemoteGattServiceChromeOS;
// The BluetoothAdapterChromeOS class implements BluetoothAdapter for the
// Chrome OS platform.
//
+// All methods are called from the dbus origin / UI thread and are generally
+// not assumed to be thread-safe.
+//
+// This class interacts with sockets using the BluetoothSocketThread to ensure
+// single-threaded calls, and posts tasks to the UI thread.
+//
// Methods tolerate a shutdown scenario where BluetoothAdapterChromeOS::Shutdown
// causes IsPresent to return false just before the dbus system is shutdown but
// while references to the BluetoothAdapterChromeOS object still exists.
@@ -109,8 +115,8 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothAdapterChromeOS
BluetoothDeviceChromeOS* GetDeviceWithPath(
const dbus::ObjectPath& object_path);
- // Announce to observers a change in device state that is not reflected by
- // its D-Bus properties.
+ // Announces to observers a change in device state that is not reflected by
+ // its D-Bus properties. |device| is owned by the caller and cannot be NULL.
armansito 2015/06/24 21:37:10 nit: Remove extra space before "|device|" in secon
void NotifyDeviceChanged(BluetoothDeviceChromeOS* device);
// The following methods are used to send various GATT observer events to

Powered by Google App Engine
This is Rietveld 408576698