Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2030)

Unified Diff: device/bluetooth/bluetooth_device_chromeos.h

Issue 1124883004: Submission for C++ Readability (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address first round of review comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: device/bluetooth/bluetooth_device_chromeos.h
diff --git a/device/bluetooth/bluetooth_device_chromeos.h b/device/bluetooth/bluetooth_device_chromeos.h
index 236b950fd8a1e03d87ec7768f239e08ea330cb09..858d9381f6c39e0348895b03ad0eae75a3752021 100644
--- a/device/bluetooth/bluetooth_device_chromeos.h
+++ b/device/bluetooth/bluetooth_device_chromeos.h
@@ -28,6 +28,11 @@ class BluetoothPairingChromeOS;
// The BluetoothDeviceChromeOS class implements BluetoothDevice for the
// Chrome OS platform.
+//
+// This class is not thread-safe, but is only called from the UI thread.
+//
+// A socket thread is used to create sockets but posts all callbacks on the UI
+// thread.
class DEVICE_BLUETOOTH_EXPORT BluetoothDeviceChromeOS
: public device::BluetoothDevice,
public BluetoothGattServiceClient::Observer {
@@ -92,7 +97,7 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDeviceChromeOS
BluetoothAdapterChromeOS* adapter() const { return adapter_; }
protected:
- // BluetoothDevice override
+ // BluetoothDevice override
std::string GetDeviceName() const override;
private:
@@ -198,3 +203,4 @@ class DEVICE_BLUETOOTH_EXPORT BluetoothDeviceChromeOS
} // namespace chromeos
#endif // DEVICE_BLUETOOTH_BLUETOOTH_DEVICE_CHROMEOS_H
+

Powered by Google App Engine
This is Rietveld 408576698