chromeos/dbus/fake_bluetooth_profile_service_provider.cc - Issue 1124883004: Submission for C++ Readability

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/fake_bluetooth_profile_service_provider.cc

Issue 1124883004: Submission for C++ Readability (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address first round of review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/fake_bluetooth_profile_service_provider.cc

diff --git a/chromeos/dbus/fake_bluetooth_profile_service_provider.cc b/chromeos/dbus/fake_bluetooth_profile_service_provider.cc

index 95467f1a425b41afc2808f467e25a37f4d2cf324..a1f44eb9cc453a68f6bfeee93cefdf926cd25335 100644

--- a/chromeos/dbus/fake_bluetooth_profile_service_provider.cc

+++ b/chromeos/dbus/fake_bluetooth_profile_service_provider.cc

@@ -31,8 +31,8 @@ FakeBluetoothProfileServiceProvider::~FakeBluetoothProfileServiceProvider() {

fake_bluetooth_profile_manager_client->UnregisterProfileServiceProvider(this);

}

-void FakeBluetoothProfileServiceProvider::Release() {

- VLOG(1) << object_path_.value() << ": Release";

+void FakeBluetoothProfileServiceProvider::Released() {

+ VLOG(1) << object_path_.value() << ": Released";

delegate_->Released();

}