Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chromeos/dbus/fake_bluetooth_profile_manager_client.cc

Issue 1124883004: Submission for C++ Readability (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address first round of review comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/fake_bluetooth_profile_manager_client.cc
diff --git a/chromeos/dbus/fake_bluetooth_profile_manager_client.cc b/chromeos/dbus/fake_bluetooth_profile_manager_client.cc
index e8726ea783b8cfa51e8f33f398f13e03737f65a0..505353ea3f918e977ababdd5645b6a42c9b309d2 100644
--- a/chromeos/dbus/fake_bluetooth_profile_manager_client.cc
+++ b/chromeos/dbus/fake_bluetooth_profile_manager_client.cc
@@ -4,7 +4,6 @@
#include "chromeos/dbus/fake_bluetooth_profile_manager_client.h"
-
#include "base/logging.h"
#include "base/message_loop/message_loop.h"
#include "chromeos/dbus/fake_bluetooth_profile_service_provider.h"
@@ -47,7 +46,7 @@ void FakeBluetoothProfileManagerClient::RegisterProfile(
return;
}
- // check options for channel & psm
+ // TODO(jamuraa): check options for channel & psm
ServiceProviderMap::iterator iter = service_provider_map_.find(profile_path);
if (iter == service_provider_map_.end()) {
@@ -106,8 +105,9 @@ FakeBluetoothProfileManagerClient::GetProfileServiceProvider(
const std::string& uuid) {
ProfileMap::iterator iter = profile_map_.find(uuid);
if (iter == profile_map_.end())
- return NULL;
+ return nullptr;
return service_provider_map_[iter->second];
}
} // namespace chromeos
+
omoikane 2015/06/23 01:23:40 This trailing blank line is redundant and should b

Powered by Google App Engine
This is Rietveld 408576698