Submission for C++ Readability

device/bluetooth/bluetooth_socket_chromeos_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/memory/ref_counted.h"
 #include "base/message_loop/message_loop.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/fake_bluetooth_adapter_client.h"
 #include "chromeos/dbus/fake_bluetooth_agent_manager_client.h"
@@ skipping 58 matching lines @@
     dbus_setter->SetBluetoothProfileManagerClient(
         scoped_ptr<BluetoothProfileManagerClient>(
             new FakeBluetoothProfileManagerClient));
 
     BluetoothSocketThread::Get();
 
     // Grab a pointer to the adapter.
     device::BluetoothAdapterFactory::GetAdapter(
         base::Bind(&BluetoothSocketChromeOSTest::AdapterCallback,
                    base::Unretained(this)));
-    ASSERT_TRUE(adapter_.get() != NULL);
+    ASSERT_TRUE(adapter_.get() != nullptr);
     ASSERT_TRUE(adapter_->IsInitialized());
     ASSERT_TRUE(adapter_->IsPresent());
 
     // Turn on the adapter.
     adapter_->SetPowered(
         true,
         base::Bind(&base::DoNothing),
         base::Bind(&base::DoNothing));
     ASSERT_TRUE(adapter_->IsPowered());
   }
 
   void TearDown() override {
-    adapter_ = NULL;
+    adapter_ = nullptr;
     BluetoothSocketThread::CleanupForTesting();
     DBusThreadManager::Shutdown();
   }
 
   void AdapterCallback(scoped_refptr<BluetoothAdapter> adapter) {
     adapter_ = adapter;
   }
 
   void SuccessCallback() {
     ++success_callback_count_;
@@ skipping 74 matching lines @@
   int last_bytes_sent_;
   int last_bytes_received_;
   scoped_refptr<net::IOBuffer> last_io_buffer_;
   BluetoothSocket::ErrorReason last_reason_;
   const BluetoothDevice* last_device_;
 };
 
 TEST_F(BluetoothSocketChromeOSTest, Connect) {
   BluetoothDevice* device = adapter_->GetDevice(
       FakeBluetoothDeviceClient::kPairedDeviceAddress);
-  ASSERT_TRUE(device != NULL);
+  ASSERT_TRUE(device != nullptr);
 
   device->ConnectToService(
       BluetoothUUID(FakeBluetoothProfileManagerClient::kRfcommUuid),
       base::Bind(&BluetoothSocketChromeOSTest::ConnectToServiceSuccessCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothSocketChromeOSTest::ErrorCallback,
                  base::Unretained(this)));
   message_loop_.Run();
 
   EXPECT_EQ(1U, success_callback_count_);
   EXPECT_EQ(0U, error_callback_count_);
-  EXPECT_TRUE(last_socket_.get() != NULL);
+  EXPECT_TRUE(last_socket_.get() != nullptr);
 
   // Take ownership of the socket for the remainder of the test.
   scoped_refptr<BluetoothSocket> socket = last_socket_;
-  last_socket_ = NULL;
+  last_socket_ = nullptr;
   success_callback_count_ = 0;
   error_callback_count_ = 0;
 
   // Send data to the socket, expect all of the data to be sent.
   scoped_refptr<net::StringIOBuffer> write_buffer(
       new net::StringIOBuffer("test"));
 
   socket->Send(write_buffer.get(), write_buffer->size(),
                base::Bind(&BluetoothSocketChromeOSTest::SendSuccessCallback,
                           base::Unretained(this)),
@@ skipping 14 matching lines @@
       4096,
       base::Bind(&BluetoothSocketChromeOSTest::ReceiveSuccessCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothSocketChromeOSTest::ReceiveErrorCallback,
                  base::Unretained(this)));
   message_loop_.Run();
 
   EXPECT_EQ(1U, success_callback_count_);
   EXPECT_EQ(0U, error_callback_count_);
   EXPECT_EQ(4, last_bytes_received_);
-  EXPECT_TRUE(last_io_buffer_.get() != NULL);
+  EXPECT_TRUE(last_io_buffer_.get() != nullptr);
 
   // Take ownership of the received buffer.
   scoped_refptr<net::IOBuffer> read_buffer = last_io_buffer_;
-  last_io_buffer_ = NULL;
+  last_io_buffer_ = nullptr;
   success_callback_count_ = 0;
   error_callback_count_ = 0;
 
   std::string data = std::string(read_buffer->data(), last_bytes_received_);
   EXPECT_EQ("test", data);
 
-  read_buffer = NULL;
+  read_buffer = nullptr;
 
   // Receive data again; the socket will have been closed, this should cause a
   // disconnected error to be returned via the error callback.
   socket->Receive(
       4096,
       base::Bind(&BluetoothSocketChromeOSTest::ReceiveSuccessCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothSocketChromeOSTest::ReceiveErrorCallback,
                  base::Unretained(this)));
   message_loop_.Run();
@@ skipping 38 matching lines @@
       BluetoothAdapter::ServiceOptions(),
       base::Bind(&BluetoothSocketChromeOSTest::CreateServiceSuccessCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothSocketChromeOSTest::ErrorCallback,
                  base::Unretained(this)));
 
   message_loop_.Run();
 
   EXPECT_EQ(1U, success_callback_count_);
   EXPECT_EQ(0U, error_callback_count_);
-  EXPECT_TRUE(last_socket_.get() != NULL);
+  EXPECT_TRUE(last_socket_.get() != nullptr);
 
   // Take ownership of the socket for the remainder of the test.
   scoped_refptr<BluetoothSocket> server_socket = last_socket_;
-  last_socket_ = NULL;
+  last_socket_ = nullptr;
   success_callback_count_ = 0;
   error_callback_count_ = 0;
 
   // Simulate an incoming connection by just calling the ConnectProfile method
   // of the underlying fake device client (from the BlueZ point of view,
   // outgoing and incoming look the same).
   //
   // This is done before the Accept() call to simulate a pending call at the
   // point that Accept() is called.
   FakeBluetoothDeviceClient* fake_bluetooth_device_client =
       static_cast<FakeBluetoothDeviceClient*>(
           DBusThreadManager::Get()->GetBluetoothDeviceClient());
   BluetoothDevice* device = adapter_->GetDevice(
       FakeBluetoothDeviceClient::kPairedDeviceAddress);
-  ASSERT_TRUE(device != NULL);
+  ASSERT_TRUE(device != nullptr);
   fake_bluetooth_device_client->ConnectProfile(
       static_cast<BluetoothDeviceChromeOS*>(device)->object_path(),
       FakeBluetoothProfileManagerClient::kRfcommUuid,
       base::Bind(&base::DoNothing),
       base::Bind(&DoNothingDBusErrorCallback));
 
   message_loop_.RunUntilIdle();
 
   server_socket->Accept(
       base::Bind(&BluetoothSocketChromeOSTest::AcceptSuccessCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothSocketChromeOSTest::ErrorCallback,
                  base::Unretained(this)));
 
   message_loop_.Run();
 
   EXPECT_EQ(1U, success_callback_count_);
   EXPECT_EQ(0U, error_callback_count_);
-  EXPECT_TRUE(last_socket_.get() != NULL);
+  EXPECT_TRUE(last_socket_.get() != nullptr);
 
   // Take ownership of the client socket for the remainder of the test.
   scoped_refptr<BluetoothSocket> client_socket = last_socket_;
-  last_socket_ = NULL;
+  last_socket_ = nullptr;
   success_callback_count_ = 0;
   error_callback_count_ = 0;
 
   // Close our end of the client socket.
   client_socket->Disconnect(
       base::Bind(&BluetoothSocketChromeOSTest::SuccessCallback,
                  base::Unretained(this)));
 
   message_loop_.Run();
 
   EXPECT_EQ(1U, success_callback_count_);
-  client_socket = NULL;
+  client_socket = nullptr;
   success_callback_count_ = 0;
   error_callback_count_ = 0;
 
   // Run a second connection test, this time calling Accept() before the
   // incoming connection comes in.
   server_socket->Accept(
       base::Bind(&BluetoothSocketChromeOSTest::AcceptSuccessCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothSocketChromeOSTest::ErrorCallback,
                  base::Unretained(this)));
 
   message_loop_.RunUntilIdle();
 
   fake_bluetooth_device_client->ConnectProfile(
       static_cast<BluetoothDeviceChromeOS*>(device)->object_path(),
       FakeBluetoothProfileManagerClient::kRfcommUuid,
       base::Bind(&base::DoNothing),
       base::Bind(&DoNothingDBusErrorCallback));
 
   message_loop_.Run();
 
   EXPECT_EQ(1U, success_callback_count_);
   EXPECT_EQ(0U, error_callback_count_);
-  EXPECT_TRUE(last_socket_.get() != NULL);
+  EXPECT_TRUE(last_socket_.get() != nullptr);
 
   // Take ownership of the client socket for the remainder of the test.
   client_socket = last_socket_;
-  last_socket_ = NULL;
+  last_socket_ = nullptr;
   success_callback_count_ = 0;
   error_callback_count_ = 0;
 
   // Close our end of the client socket.
   client_socket->Disconnect(
       base::Bind(&BluetoothSocketChromeOSTest::SuccessCallback,
                  base::Unretained(this)));
 
   message_loop_.Run();
 
   EXPECT_EQ(1U, success_callback_count_);
-  client_socket = NULL;
+  client_socket = nullptr;
   success_callback_count_ = 0;
   error_callback_count_ = 0;
 
   // Now close the server socket.
   server_socket->Disconnect(
       base::Bind(&BluetoothSocketChromeOSTest::ImmediateSuccessCallback,
                  base::Unretained(this)));
 
   message_loop_.RunUntilIdle();
 
@@ skipping 12 matching lines @@
       BluetoothUUID(FakeBluetoothProfileManagerClient::kRfcommUuid),
       BluetoothAdapter::ServiceOptions(),
       base::Bind(&BluetoothSocketChromeOSTest::CreateServiceSuccessCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothSocketChromeOSTest::ErrorCallback,
                  base::Unretained(this)));
   message_loop_.Run();
 
   EXPECT_EQ(1U, success_callback_count_);
   EXPECT_EQ(0U, error_callback_count_);
-  EXPECT_TRUE(last_socket_.get() != NULL);
+  EXPECT_TRUE(last_socket_.get() != nullptr);
 
   // Take ownership of the socket for the remainder of the test.
   scoped_refptr<BluetoothSocket> socket = last_socket_;
-  last_socket_ = NULL;
+  last_socket_ = nullptr;
   success_callback_count_ = 0;
   error_callback_count_ = 0;
 
   // But there shouldn't be a profile registered yet.
   FakeBluetoothProfileManagerClient* fake_bluetooth_profile_manager_client =
       static_cast<FakeBluetoothProfileManagerClient*>(
           DBusThreadManager::Get()->GetBluetoothProfileManagerClient());
   FakeBluetoothProfileServiceProvider* profile_service_provider =
       fake_bluetooth_profile_manager_client->GetProfileServiceProvider(
           FakeBluetoothProfileManagerClient::kRfcommUuid);
-  EXPECT_TRUE(profile_service_provider == NULL);
+  EXPECT_TRUE(profile_service_provider == nullptr);
 
   // Make the adapter visible. This should register a profile.
   fake_bluetooth_adapter_client->SetVisible(true);
 
   message_loop_.RunUntilIdle();
 
   profile_service_provider =
       fake_bluetooth_profile_manager_client->GetProfileServiceProvider(
           FakeBluetoothProfileManagerClient::kRfcommUuid);
-  EXPECT_TRUE(profile_service_provider != NULL);
+  EXPECT_TRUE(profile_service_provider != nullptr);
 
   // Cleanup the socket.
   socket->Disconnect(
       base::Bind(&BluetoothSocketChromeOSTest::ImmediateSuccessCallback,
                  base::Unretained(this)));
 
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(1U, success_callback_count_);
 }
 
 TEST_F(BluetoothSocketChromeOSTest, ListenAcrossAdapterRestart) {
   // The fake adapter starts off visible by default.
   FakeBluetoothAdapterClient* fake_bluetooth_adapter_client =
       static_cast<FakeBluetoothAdapterClient*>(
           DBusThreadManager::Get()->GetBluetoothAdapterClient());
 
   adapter_->CreateRfcommService(
       BluetoothUUID(FakeBluetoothProfileManagerClient::kRfcommUuid),
       BluetoothAdapter::ServiceOptions(),
       base::Bind(&BluetoothSocketChromeOSTest::CreateServiceSuccessCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothSocketChromeOSTest::ErrorCallback,
                  base::Unretained(this)));
   message_loop_.Run();
 
   EXPECT_EQ(1U, success_callback_count_);
   EXPECT_EQ(0U, error_callback_count_);
-  EXPECT_TRUE(last_socket_.get() != NULL);
+  EXPECT_TRUE(last_socket_.get() != nullptr);
 
   // Take ownership of the socket for the remainder of the test.
   scoped_refptr<BluetoothSocket> socket = last_socket_;
-  last_socket_ = NULL;
+  last_socket_ = nullptr;
   success_callback_count_ = 0;
   error_callback_count_ = 0;
 
   // Make sure the profile was registered with the daemon.
   FakeBluetoothProfileManagerClient* fake_bluetooth_profile_manager_client =
       static_cast<FakeBluetoothProfileManagerClient*>(
           DBusThreadManager::Get()->GetBluetoothProfileManagerClient());
   FakeBluetoothProfileServiceProvider* profile_service_provider =
       fake_bluetooth_profile_manager_client->GetProfileServiceProvider(
           FakeBluetoothProfileManagerClient::kRfcommUuid);
-  EXPECT_TRUE(profile_service_provider != NULL);
+  EXPECT_TRUE(profile_service_provider != nullptr);
 
   // Make the adapter invisible, and fiddle with the profile fake to unregister
   // the profile since this doesn't happen automatically.
   fake_bluetooth_adapter_client->SetVisible(false);
 
   message_loop_.RunUntilIdle();
 
   // Then make the adapter visible again. This should re-register the profile.
   fake_bluetooth_adapter_client->SetVisible(true);
 
   message_loop_.RunUntilIdle();
 
   profile_service_provider =
       fake_bluetooth_profile_manager_client->GetProfileServiceProvider(
           FakeBluetoothProfileManagerClient::kRfcommUuid);
-  EXPECT_TRUE(profile_service_provider != NULL);
+  EXPECT_TRUE(profile_service_provider != nullptr);
 
   // Cleanup the socket.
   socket->Disconnect(
       base::Bind(&BluetoothSocketChromeOSTest::ImmediateSuccessCallback,
                  base::Unretained(this)));
 
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(1U, success_callback_count_);
 }
 
 TEST_F(BluetoothSocketChromeOSTest, PairedConnectFails) {
   BluetoothDevice* device = adapter_->GetDevice(
       FakeBluetoothDeviceClient::kPairedUnconnectableDeviceAddress);
-  ASSERT_TRUE(device != NULL);
+  ASSERT_TRUE(device != nullptr);
 
   device->ConnectToService(
       BluetoothUUID(FakeBluetoothProfileManagerClient::kRfcommUuid),
       base::Bind(&BluetoothSocketChromeOSTest::ConnectToServiceSuccessCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothSocketChromeOSTest::ErrorCallback,
                  base::Unretained(this)));
   message_loop_.Run();
 
   EXPECT_EQ(0U, success_callback_count_);
   EXPECT_EQ(1U, error_callback_count_);
-  EXPECT_TRUE(last_socket_.get() == NULL);
+  EXPECT_TRUE(last_socket_.get() == nullptr);
 
   device->ConnectToService(
       BluetoothUUID(FakeBluetoothProfileManagerClient::kRfcommUuid),
       base::Bind(&BluetoothSocketChromeOSTest::ConnectToServiceSuccessCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothSocketChromeOSTest::ErrorCallback,
                  base::Unretained(this)));
   message_loop_.Run();
 
   EXPECT_EQ(0U, success_callback_count_);
   EXPECT_EQ(2U, error_callback_count_);
-  EXPECT_TRUE(last_socket_.get() == NULL);
+  EXPECT_TRUE(last_socket_.get() == nullptr);
 }
 
 TEST_F(BluetoothSocketChromeOSTest, SocketListenTwice) {
   adapter_->CreateRfcommService(
       BluetoothUUID(FakeBluetoothProfileManagerClient::kRfcommUuid),
       BluetoothAdapter::ServiceOptions(),
       base::Bind(&BluetoothSocketChromeOSTest::CreateServiceSuccessCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothSocketChromeOSTest::ErrorCallback,
                  base::Unretained(this)));
 
   message_loop_.Run();
 
   EXPECT_EQ(1U, success_callback_count_);
   EXPECT_EQ(0U, error_callback_count_);
-  EXPECT_TRUE(last_socket_.get() != NULL);
+  EXPECT_TRUE(last_socket_.get() != nullptr);
 
   // Take control of this socket.
   scoped_refptr<BluetoothSocket> server_socket;
   server_socket.swap(last_socket_);
 
   server_socket->Accept(
       base::Bind(&BluetoothSocketChromeOSTest::AcceptSuccessCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothSocketChromeOSTest::ErrorCallback,
                  base::Unretained(this)));
 
   server_socket->Close();
 
-  server_socket = NULL;
+  server_socket = nullptr;
 
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(1U, success_callback_count_);
   EXPECT_EQ(1U, error_callback_count_);
 
   adapter_->CreateRfcommService(
       BluetoothUUID(FakeBluetoothProfileManagerClient::kRfcommUuid),
       BluetoothAdapter::ServiceOptions(),
       base::Bind(&BluetoothSocketChromeOSTest::CreateServiceSuccessCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothSocketChromeOSTest::ErrorCallback,
                  base::Unretained(this)));
 
   message_loop_.Run();
 
   EXPECT_EQ(2U, success_callback_count_);
   EXPECT_EQ(1U, error_callback_count_);
-  EXPECT_TRUE(last_socket_.get() != NULL);
+  EXPECT_TRUE(last_socket_.get() != nullptr);
 
   // Take control of this socket.
   server_socket.swap(last_socket_);
 
   server_socket->Accept(
       base::Bind(&BluetoothSocketChromeOSTest::AcceptSuccessCallback,
                  base::Unretained(this)),
       base::Bind(&BluetoothSocketChromeOSTest::ErrorCallback,
                  base::Unretained(this)));
 
   server_socket->Close();
 
-  server_socket = NULL;
+  server_socket = nullptr;
 
   message_loop_.RunUntilIdle();
 
   EXPECT_EQ(2U, success_callback_count_);
   EXPECT_EQ(2U, error_callback_count_);
 }
 
 }  // namespace chromeos